Skip to content

Conversation

@driusan
Copy link
Collaborator

@driusan driusan commented Nov 10, 2025

This fixes various issues I found while testing #9934

  • The "edit user" link did not go to the correct URL
  • "Sites" and "Projects" were encoded as separate strings rather than plural forms of "Site" and "Project"
  • Some error messages were in the wrong namespace
  • "When generating a new password, please notify the user by checking 'Send email to user' box below!" was untranslated because the template string did not match the code
  • Translation strings from widgets were incorrectly removed
  • "Y" and "N" backend values did not need to be translated since "Yes" and "No" frontend values are already translated
  • Also added Japanese
  • Some strings in the loris template were moved, put them back in the original locations to make it easier to review

Saket Hatwar and others added 18 commits August 28, 2025 09:41
- The "edit user" link did not go to the correct URL
- "Sites" and "Projects" were encoded as separate strings rather than plural forms of "Site" and "Project"
- Some error messages were in the wrong namespace
- "When generating a new password, please notify the user by checking 'Send email to user' box below!" was untranslated because the template string did not match the code
- Translation strings from widgets were incorrectly removed
- Also added Japanese
@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: user_accounts PR or issue related to the user_accounts module labels Nov 10, 2025
@driusan driusan added the Multilingual Any tasks related to making LORIS multilingual label Nov 10, 2025
@driusan driusan merged commit d529154 into aces:main Nov 10, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: user_accounts PR or issue related to the user_accounts module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants