Return response body for errors

[praseodym]

When the Shodan HTTP API returns an error status code, such as 403 Forbidden, this library will only return a APIError object.

However, the HTTP response will usually also include data in the response body, such as {"error": "Requires membership or higher to access"}. This data is currently ignored and not available through the library.

It would be useful if this response body is also made available by the library, for example to show a more informative error message to the end user.

[achillean]

You should be able to access the specific error message from the APIException.value property

[praseodym]

The contents of the APIException.value property are hardcoded in the library, so e.g. for status code 403 the error message will always be Access denied (403 Forbidden):

shodan-python/shodan/client.py

Lines 376 to 379 in 9ed7496

	elif data.status_code == 403:
	raise APIError('Access denied (403 Forbidden)')
	elif data.status_code == 502:
	raise APIError('Bad Gateway (502)')

For some status codes, the Shodan response body will contain more detailed information that is useful to have and return to the end user.

[achillean]

I think that's because for some of those responses the body isn't JSON but you're right, we should use the JSON error message if available as that is typically more precise.