|
| 1 | +using MSIXplainer.Models; |
| 2 | +using MSIXplainer.Services; |
| 3 | +using Xunit; |
| 4 | + |
| 5 | +namespace MSIXplainer.Core.Tests; |
| 6 | + |
| 7 | +public class InstalledPackageServiceTests |
| 8 | +{ |
| 9 | + [Fact] |
| 10 | + public void ManifestPath_BuildsFromInstallLocation() |
| 11 | + { |
| 12 | + var pkg = NewPackage(installLocation: Path.Combine("C:", "apps", "myapp")); |
| 13 | + Assert.Equal( |
| 14 | + Path.Combine("C:", "apps", "myapp", "AppxManifest.xml"), |
| 15 | + pkg.ManifestPath); |
| 16 | + } |
| 17 | + |
| 18 | + [Fact] |
| 19 | + public void ManifestPath_EmptyInstallLocation_IsNull() |
| 20 | + { |
| 21 | + Assert.Null(NewPackage(installLocation: "").ManifestPath); |
| 22 | + } |
| 23 | + |
| 24 | + [Fact] |
| 25 | + public void List_OnNonWindows_ReturnsEmpty() |
| 26 | + { |
| 27 | + if (OperatingSystem.IsWindows()) |
| 28 | + return; // Only meaningful off-Windows; PackageManager is unavailable there. |
| 29 | + |
| 30 | + Assert.Empty(InstalledPackageService.List()); |
| 31 | + } |
| 32 | + |
| 33 | + [Fact] |
| 34 | + public void List_OnWindows_ReturnsMainPackagesWithValidIdentity() |
| 35 | + { |
| 36 | + if (!OperatingSystem.IsWindows()) |
| 37 | + return; |
| 38 | + |
| 39 | + var packages = InstalledPackageService.List(); |
| 40 | + |
| 41 | + // Don't assert specific packages — CI / dev images vary. Just verify the contract: |
| 42 | + // no throw, valid identity fields, every PFN is in Name_PublisherHash form, and |
| 43 | + // every row has a non-empty DisplayName (either resolved or fallen back to Name). |
| 44 | + Assert.NotNull(packages); |
| 45 | + foreach (var pkg in packages) |
| 46 | + { |
| 47 | + Assert.False(string.IsNullOrEmpty(pkg.Name), $"Name empty for {pkg.PackageFullName}"); |
| 48 | + Assert.False(string.IsNullOrEmpty(pkg.DisplayName), $"DisplayName empty for {pkg.PackageFullName}"); |
| 49 | + Assert.False(string.IsNullOrEmpty(pkg.PackageFamilyName), $"PFN empty for {pkg.Name}"); |
| 50 | + Assert.Contains("_", pkg.PackageFamilyName); |
| 51 | + Assert.DoesNotContain("ms-resource:", pkg.DisplayName); // unresolved indirections must fall back |
| 52 | + } |
| 53 | + } |
| 54 | + |
| 55 | + [Fact] |
| 56 | + public void List_OnWindows_ReturnsSortedByDisplayName() |
| 57 | + { |
| 58 | + if (!OperatingSystem.IsWindows()) |
| 59 | + return; |
| 60 | + |
| 61 | + var packages = InstalledPackageService.List(); |
| 62 | + if (packages.Count < 2) return; |
| 63 | + |
| 64 | + var displayNames = packages.Select(p => p.DisplayName).ToList(); |
| 65 | + var sorted = displayNames.OrderBy(n => n, StringComparer.OrdinalIgnoreCase).ToList(); |
| 66 | + Assert.Equal(sorted, displayNames); |
| 67 | + } |
| 68 | + |
| 69 | + [Fact] |
| 70 | + public void FindByFamilyName_EmptyOrNull_ReturnsNull() |
| 71 | + { |
| 72 | + Assert.Null(InstalledPackageService.FindByFamilyName("")); |
| 73 | + Assert.Null(InstalledPackageService.FindByFamilyName(" ")); |
| 74 | + Assert.Null(InstalledPackageService.FindByFamilyName(null!)); |
| 75 | + } |
| 76 | + |
| 77 | + [Fact] |
| 78 | + public void FindByFamilyName_OnWindows_RoundTripsKnownPackage() |
| 79 | + { |
| 80 | + if (!OperatingSystem.IsWindows()) |
| 81 | + return; |
| 82 | + |
| 83 | + var first = InstalledPackageService.List().FirstOrDefault(); |
| 84 | + if (first is null) return; // No packages on this machine — skip. |
| 85 | + |
| 86 | + var found = InstalledPackageService.FindByFamilyName(first.PackageFamilyName); |
| 87 | + Assert.NotNull(found); |
| 88 | + Assert.Equal(first.PackageFamilyName, found!.PackageFamilyName); |
| 89 | + } |
| 90 | + |
| 91 | + [Fact] |
| 92 | + public void FindByFamilyName_UnknownPackage_ReturnsNull() |
| 93 | + { |
| 94 | + if (!OperatingSystem.IsWindows()) |
| 95 | + return; |
| 96 | + |
| 97 | + Assert.Null(InstalledPackageService.FindByFamilyName( |
| 98 | + "MSIXplainer.NonExistent.Package_0000000000000")); |
| 99 | + } |
| 100 | + |
| 101 | + [Fact] |
| 102 | + public void ListWithoutIcons_OnNonWindows_ReturnsEmpty() |
| 103 | + { |
| 104 | + if (OperatingSystem.IsWindows()) |
| 105 | + return; |
| 106 | + |
| 107 | + Assert.Empty(InstalledPackageService.ListWithoutIcons()); |
| 108 | + } |
| 109 | + |
| 110 | + [Fact] |
| 111 | + public void ListWithoutIcons_OnWindows_AllRowsHaveNullIcons() |
| 112 | + { |
| 113 | + if (!OperatingSystem.IsWindows()) |
| 114 | + return; |
| 115 | + |
| 116 | + var packages = InstalledPackageService.ListWithoutIcons(); |
| 117 | + Assert.NotNull(packages); |
| 118 | + // Fast path explicitly skips icon resolution — every row must come back with null bytes. |
| 119 | + Assert.All(packages, p => Assert.Null(p.IconBytes)); |
| 120 | + } |
| 121 | + |
| 122 | + [Fact] |
| 123 | + public void ListWithoutIcons_OnWindows_ReturnsSameIdentitiesAsList() |
| 124 | + { |
| 125 | + if (!OperatingSystem.IsWindows()) |
| 126 | + return; |
| 127 | + |
| 128 | + var fast = InstalledPackageService.ListWithoutIcons() |
| 129 | + .Select(p => p.PackageFullName) |
| 130 | + .OrderBy(n => n, StringComparer.Ordinal) |
| 131 | + .ToList(); |
| 132 | + var full = InstalledPackageService.List() |
| 133 | + .Select(p => p.PackageFullName) |
| 134 | + .OrderBy(n => n, StringComparer.Ordinal) |
| 135 | + .ToList(); |
| 136 | + |
| 137 | + Assert.Equal(full, fast); |
| 138 | + } |
| 139 | + |
| 140 | + [Fact] |
| 141 | + public void ResolveIcon_AlreadyHasIcon_ReturnsSameInstance() |
| 142 | + { |
| 143 | + var pkg = NewPackage(installLocation: "C:\\nope") with { IconBytes = [0x01, 0x02] }; |
| 144 | + var resolved = InstalledPackageService.ResolveIcon(pkg); |
| 145 | + Assert.Same(pkg, resolved); |
| 146 | + } |
| 147 | + |
| 148 | + [Fact] |
| 149 | + public void ResolveIcon_EmptyInstallLocation_ReturnsSameInstance() |
| 150 | + { |
| 151 | + var pkg = NewPackage(installLocation: ""); |
| 152 | + var resolved = InstalledPackageService.ResolveIcon(pkg); |
| 153 | + Assert.Same(pkg, resolved); |
| 154 | + } |
| 155 | + |
| 156 | + [Fact] |
| 157 | + public void ResolveIcon_NonExistentFolder_ReturnsSameInstanceWithNullBytes() |
| 158 | + { |
| 159 | + var pkg = NewPackage(installLocation: Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString())); |
| 160 | + var resolved = InstalledPackageService.ResolveIcon(pkg); |
| 161 | + Assert.Null(resolved.IconBytes); |
| 162 | + } |
| 163 | + |
| 164 | + [Fact] |
| 165 | + public void ResolveIcon_OnWindows_PopulatesIconForRealPackage() |
| 166 | + { |
| 167 | + if (!OperatingSystem.IsWindows()) |
| 168 | + return; |
| 169 | + |
| 170 | + // Pick a package whose icon-with full-pass actually resolves, then verify |
| 171 | + // ResolveIcon arrives at the same bytes when started from the icon-less version. |
| 172 | + var withIcons = InstalledPackageService.List(); |
| 173 | + var sample = withIcons.FirstOrDefault(p => p.IconBytes is { Length: > 0 }); |
| 174 | + if (sample is null) return; // No package on this box exposed an icon — skip. |
| 175 | + |
| 176 | + var stripped = sample with { IconBytes = null }; |
| 177 | + var resolved = InstalledPackageService.ResolveIcon(stripped); |
| 178 | + |
| 179 | + Assert.NotNull(resolved.IconBytes); |
| 180 | + Assert.Equal(sample.IconBytes!.Length, resolved.IconBytes!.Length); |
| 181 | + } |
| 182 | + |
| 183 | + private static InstalledPackage NewPackage(string installLocation) => new() |
| 184 | + { |
| 185 | + Name = "X", |
| 186 | + DisplayName = "X", |
| 187 | + PackageFamilyName = "X_abc", |
| 188 | + PackageFullName = "X_1.0.0.0_x64__abc", |
| 189 | + Version = "1.0.0.0", |
| 190 | + Publisher = "CN=X", |
| 191 | + InstallLocation = installLocation, |
| 192 | + Architecture = "X64" |
| 193 | + }; |
| 194 | +} |
0 commit comments