Skip to content

Commit 2f89d74

Browse files
committed
Compute monitoring vis dims
1 parent 735e4c3 commit 2f89d74

File tree

2 files changed

+21
-39
lines changed

2 files changed

+21
-39
lines changed

src/monitoring/instruments/halo_doppler_lidar.py

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,7 @@ def plot_housekeeping_variable(
119119
format_time_axis(ax)
120120
pretty_ax(ax, grid="y")
121121
fig_ = save_fig(fig)
122-
return MonitoringVisualization(
123-
fig_.bytes, variable, Dimensions(fig_.width, fig_.height)
124-
)
122+
return MonitoringVisualization(fig_.bytes, variable, Dimensions(fig, [ax]))
125123

126124

127125
def monitor_background(
@@ -212,9 +210,7 @@ def plot_background_profile(
212210
format_time_axis(ax)
213211
pretty_ax_2d(ax)
214212
fig_ = save_fig(fig)
215-
return MonitoringVisualization(
216-
fig_.bytes, variable, Dimensions(fig_.width, fig_.height)
217-
)
213+
return MonitoringVisualization(fig_.bytes, variable, Dimensions(fig, [ax]))
218214

219215

220216
def plot_background_variance(
@@ -227,9 +223,7 @@ def plot_background_variance(
227223
format_time_axis(ax)
228224
pretty_ax(ax, grid="y")
229225
fig_ = save_fig(fig)
230-
return MonitoringVisualization(
231-
fig_.bytes, variable, Dimensions(fig_.width, fig_.height)
232-
)
226+
return MonitoringVisualization(fig_.bytes, variable, Dimensions(fig, [ax]))
233227

234228

235229
def plot_time_averaged_background_profile(
@@ -249,9 +243,7 @@ def plot_time_averaged_background_profile(
249243

250244
pretty_ax(ax, grid="y")
251245
fig_ = save_fig(fig)
252-
return MonitoringVisualization(
253-
fig_.bytes, variable, Dimensions(fig_.width, fig_.height)
254-
)
246+
return MonitoringVisualization(fig_.bytes, variable, Dimensions(fig, [ax]))
255247

256248

257249
def monitor_signal(
@@ -352,9 +344,7 @@ def plot_radial_velocity_histogram(
352344
ax.set_ylabel("Count")
353345
pretty_ax(ax, grid="both")
354346
fig_ = save_fig(fig)
355-
return MonitoringVisualization(
356-
fig_.bytes, variable, Dimensions(fig_.width, fig_.height)
357-
)
347+
return MonitoringVisualization(fig_.bytes, variable, Dimensions(fig, [ax]))
358348

359349

360350
def plot_signal_radial_velocity(
@@ -370,6 +360,4 @@ def plot_signal_radial_velocity(
370360
ax.set_ylabel("Radial velocity")
371361
pretty_ax(ax)
372362
fig_ = save_fig(fig)
373-
return MonitoringVisualization(
374-
fig_.bytes, variable, Dimensions(fig_.width, fig_.height)
375-
)
363+
return MonitoringVisualization(fig_.bytes, variable, Dimensions(fig, [ax]))

src/monitoring/monitoring_file.py

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,7 @@
99
from monitoring.product import MonitoringProduct, MonitoringVariable
1010
from monitoring.utils import get_apis
1111

12-
13-
@dataclass
14-
class Dimensions:
15-
width: int
16-
height: int
17-
margin_top: int | None = None
18-
margin_right: int | None = None
19-
margin_bottom: int | None = None
20-
margin_left: int | None = None
21-
22-
def as_payload_dict(self) -> dict[str, int | None]:
23-
return {
24-
"width": self.width,
25-
"height": self.height,
26-
"marginTop": self.margin_top,
27-
"marginRight": self.margin_right,
28-
"marginBottom": self.margin_bottom,
29-
"marginLeft": self.margin_left,
30-
}
12+
from cloudnetpy.plotting.plotting import Dimensions
3113

3214

3315
@dataclass
@@ -37,6 +19,17 @@ class MonitoringVisualization:
3719
dimensions: Dimensions
3820

3921

22+
def _dimemsions_as_payload(dim: Dimensions) -> dict[str, int]:
23+
return {
24+
"width": dim.width,
25+
"height": dim.height,
26+
"marginTop": dim.margin_top,
27+
"marginRight": dim.margin_right,
28+
"marginBottom": dim.margin_bottom,
29+
"marginLeft": dim.margin_left,
30+
}
31+
32+
4033
@dataclass
4134
class MonitoringFile:
4235
instrument: Instrument
@@ -81,6 +74,7 @@ def upload(self) -> None:
8174
"s3key": s3key,
8275
"sourceFileUuid": file_uuid,
8376
"variableId": vis.variable.id,
77+
**_dimemsions_as_payload(vis.dimensions),
8478
}
8579
res = md_api.post("monitoring-visualizations", payload=payload)
8680
if not res.ok:
@@ -101,8 +95,8 @@ def generate_s3_key(
10195

10296
def _period_for_s3key(p: Period) -> str:
10397
if isinstance(p, AllPeriod):
104-
return "All"
105-
period_str = p.period.capitalize()
98+
return "all"
99+
period_str = p.period
106100
match p.period:
107101
case "year":
108102
date_str = p.start_date.strftime("%Y")

0 commit comments

Comments
 (0)