From 399604de0c7dc8e2a70a13622f211736982b98f9 Mon Sep 17 00:00:00 2001 From: Stephen Nicholas Swatman Date: Thu, 5 Feb 2026 13:45:52 +0100 Subject: [PATCH] Fix incorrect assertion in `build_tracks` kernel This commit fixes an incorrect assertion in the `build_tracks` kernel to account for the fact that this kernel can now produce fitted tracks. It also re-enables the check for duplicate measurements on each track. --- .../traccc/finding/device/impl/build_tracks.ipp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/device/common/include/traccc/finding/device/impl/build_tracks.ipp b/device/common/include/traccc/finding/device/impl/build_tracks.ipp index cbd5cc23e9..5150a614a4 100644 --- a/device/common/include/traccc/finding/device/impl/build_tracks.ipp +++ b/device/common/include/traccc/finding/device/impl/build_tracks.ipp @@ -220,13 +220,15 @@ TRACCC_HOST_DEVICE inline void build_tracks( #ifndef NDEBUG // Assert that we did not make any duplicate track states. for (const auto& i : track.constituent_links()) { - assert(i.type == edm::track_constituent_link::measurement); + if (run_mbf) { + assert(i.type == edm::track_constituent_link::track_state); + } else { + assert(i.type == edm::track_constituent_link::measurement); + } for (const auto& j : track.constituent_links()) { - assert(j.type == edm::track_constituent_link::measurement); if (i.index != j.index) { - // TODO: Re-enable me! - // assert(measurements.at(i->index).identifier() != - // measurement.at(j->index).identifier()); + assert(measurements.at(i.index).identifier() != + measurements.at(j.index).identifier()); } } }