Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seriatim lifelib model #48

Closed
MatthewCaseres opened this issue Sep 17, 2023 · 3 comments
Closed

Seriatim lifelib model #48

MatthewCaseres opened this issue Sep 17, 2023 · 3 comments

Comments

@MatthewCaseres
Copy link
Contributor

Seems important based on discussion from here - https://modelx.io/blog/2023/08/19/enhanced-speed-for-exported-lifelib-models/

@serenity4
Copy link
Contributor

I think this should be done in conjunction with #41, as mentioned in the article there is a large speedup for exported Seriatim models w.r.t. non-exported Seriatim models. Otherwise, it wouldn't really be a fair benchmark.

@MatthewCaseres
Copy link
Contributor Author

Yep totally agree. Makes most sense to resolve these issues together.

@MatthewCaseres
Copy link
Contributor Author

This issue is being closed because NumPy does calculate the seriatim values and provides a nice syntax for aggregating them as well. Function call overhead is too high and vectorization is not available either with seriatim methods that cache single values at a time instead of arrays.

It does allow for complex control flow, but that is not currently a requirement to correctly calculate any of the numbers that we currently are calculating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants