diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..62e430aca --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' \ No newline at end of file diff --git a/ada-project-docs/wave_01.md b/ada-project-docs/wave_01.md index 521e4666d..dac7e77a7 100644 --- a/ada-project-docs/wave_01.md +++ b/ada-project-docs/wave_01.md @@ -61,8 +61,7 @@ As a client, I want to be able to make a `POST` request to `/tasks` with the fol ```json { "title": "A Brand New Task", - "description": "Test Description", - "completed_at": null + "description": "Test Description" } ``` @@ -227,14 +226,3 @@ If the HTTP request is missing `description`, we should also get this response: } ``` -#### Missing `completed_at` - -If the HTTP request is missing `completed_at`, we should also get this response: - -`400 Bad Request` - -```json -{ - "details": "Invalid data" -} -``` diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..7f984716f 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -30,5 +30,9 @@ def create_app(test_config=None): migrate.init_app(app, db) # Register Blueprints here + from .tasks_routes import tasks_bp + app.register_blueprint(tasks_bp) + from .goal_routes import goals_bp + app.register_blueprint(goals_bp) return app diff --git a/app/goal_routes.py b/app/goal_routes.py new file mode 100644 index 000000000..b297fe652 --- /dev/null +++ b/app/goal_routes.py @@ -0,0 +1,121 @@ + +from flask import Blueprint, jsonify, make_response, request, abort +from app import db +from app.models.goal import Goal +from app.models.task import Task +from datetime import datetime +import os +from app.tasks_routes import validate_task_id + +goals_bp = Blueprint("goal_bp", __name__, url_prefix="/goals") + + +def validate_goal_id(goal_id): + try: + id = int(goal_id) + except: + abort(make_response( + {"message": f"goal {goal_id} invalid. Must be numerical"}, 400)) + + goal = Goal.query.get(goal_id) + + if not goal: + abort(make_response({"message": f"Goal {goal_id} not found"}, 404)) + + return goal + + +@goals_bp.route("", methods=["GET"]) +def get_goals(): + title_query = request.args.get("title") + if title_query: + goals = Goal.query.filter_by(title=title_query) + else: + goals = Goal.query.all() + print(goals) + goal_response = [] + for goal in goals: + goal_response.append(goal.to_json()) + return jsonify(goal_response) + + +@goals_bp.route("/", methods=["GET"]) +def get_single_goal(goal_id): + goal = validate_goal_id(goal_id) + return{"goal": goal.to_json()} + + +@goals_bp.route("", methods=["POST"]) +def create_goal(): + request_body = request.get_json() + try: + new_goal = Goal(title=request_body["title"]) + except KeyError: + return make_response({"details": "Invalid data"}, 400) + + db.session.add(new_goal) + db.session.commit() + + return {"goal": new_goal.to_json()}, 201 + + +@goals_bp.route("/", methods=["PUT"]) +def update_goal(goal_id): + found_goal = validate_goal_id(goal_id) + + request_body = request.get_json() + + found_goal.title = request_body["title"] + + db.session.commit() + + return {"goal": found_goal.to_json()}, 200 + + +@goals_bp.route("/", methods=["DELETE"]) +def delete_goal(goal_id): + found_goal = validate_goal_id(goal_id) + + db.session.delete(found_goal) + db.session.commit() + + return jsonify({"details": f'Goal {found_goal.goal_id} "{found_goal.title}" successfully deleted'}) + + +@ goals_bp.route("//tasks", methods=["POST"]) +def add_tasks(goal_id): + goal = validate_goal_id(goal_id) + request_body = request.get_json() + task_ids = request_body["task_ids"] + + for task_id in task_ids: + valid_task = validate_task_id(task_id) + goal.tasks.append(valid_task) + # tasks = [] + # for id in task_ids: + # tasks.append(validate_task_id(id)) + # for task in tasks: + # task.goal_id = goal.goal_id + + db.session.commit() + return jsonify({"id": goal.goal_id, + "task_ids": task_ids}) + + +@ goals_bp.route("//tasks", methods=["GET"]) +def get_tasks(goal_id): + goal = validate_goal_id(goal_id) + tasks = [] + + for task in goal.tasks: + tasks.append(({ + "id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at)})) + if task.goal_id: + tasks[-1]["goal_id"] = task.goal_id + + return jsonify({"id": goal.goal_id, + "title": goal.title, + "tasks": tasks}) diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..544619cd0 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -2,4 +2,10 @@ class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + goal_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + tasks = db.relationship("Task", back_populates="goal") + + def to_json(self): + return {"id": self.goal_id, + "title": self.title} diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..b9ff1f6fe 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -2,4 +2,9 @@ class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + task_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime) + goal_id = db.Column(db.Integer, db.ForeignKey('goal.goal_id')) + goal = db.relationship("Goal", back_populates="tasks") diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 3aae38d49..000000000 --- a/app/routes.py +++ /dev/null @@ -1 +0,0 @@ -from flask import Blueprint \ No newline at end of file diff --git a/app/tasks_routes.py b/app/tasks_routes.py new file mode 100644 index 000000000..d6371a90f --- /dev/null +++ b/app/tasks_routes.py @@ -0,0 +1,152 @@ +from flask import Blueprint, jsonify, make_response, request, abort +from app import db +from app.models.task import Task +from datetime import datetime +import sys +import os +import requests +from dotenv import load_dotenv +load_dotenv() + +tasks_bp = Blueprint("tasks_bp", __name__, url_prefix="/tasks") + +SLACK_TOKEN = os.environ.get("SLACK_TOKEN") + + +def validate_task_id(task_id): + try: + task_id = int(task_id) + except: + abort(make_response( + {"message": f"Task {task_id} invalid. Must be numerical"}, 400)) + + task = Task.query.get(task_id) + + if not task: + abort(make_response({"message": f"Task {task_id} not found"}, 404)) + + return task + + +@tasks_bp.route("", methods=["GET"]) +def get_tasks(): + sort_query = request.args.get("sort") + title_query = request.args.get("title") + if title_query: + tasks = Task.query.filter_by(title=title_query) + elif sort_query == "desc": + tasks = Task.query.order_by(Task.title.desc()).all() + elif sort_query == "asc": + tasks = Task.query.order_by(Task.title.asc()).all() + else: + tasks = Task.query.all() + tasks_response = [] + for task in tasks: + tasks_response.append({ + "id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at)}) + return jsonify(tasks_response) + + +@tasks_bp.route("/", methods=["GET"]) +def get_single_task(task_id): + task = validate_task_id(task_id) + task_reply = {"task": { + "id": task.task_id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at)}} + if task.goal_id: + task_reply["task"]["goal_id"] = task.goal_id + return task_reply + + +@tasks_bp.route("", methods=["POST"]) +def create_task(): + request_body = request.get_json() + try: + new_task = Task(title=request_body["title"], + description=request_body["description"]) + except KeyError: + return {"details": "Invalid data"}, 400 + + if "completed_at" in request_body: + new_task.completed_at = request_body["completed_at"] + + db.session.add(new_task) + db.session.commit() + + return {"task": { + "id": new_task.task_id, + "title": new_task.title, + "description": new_task.description, + "is_complete": bool(new_task.completed_at)}}, 201 + + +@tasks_bp.route("/", methods=["PUT"]) +def update_task(task_id): + found_task = validate_task_id(task_id) + + request_body = request.get_json() + + found_task.title = request_body["title"] + found_task.description = request_body["description"] + if "completed_at" in request_body: + found_task.completed_at = request_body["completed_at"] + db.session.commit() + + return {"task": + {"id": found_task.task_id, + "title": found_task.title, + "description": found_task.description, + "is_complete": bool(found_task.completed_at)}}, 200 + + +@tasks_bp.route("//mark_complete", methods=["PATCH"]) +def update_task_status(task_id): + found_task = validate_task_id(task_id) + + found_task.completed_at = datetime.now() + + db.session.commit() + + message = f"Someone just completed task {found_task.title}" + + headers = {"Authorization": "Bearer " + SLACK_TOKEN} + params = {"channel": "task-notifications", "text": message} + + requests.post('https://slack.com/api/chat.postMessage', + data=params, headers=headers) + + return {"task": + {"id": found_task.task_id, + "title": found_task.title, + "description": found_task.description, + "is_complete": bool(found_task.completed_at)}}, 200 + + +@tasks_bp.route("//mark_incomplete", methods=["PATCH"]) +def incomplete_task_status(task_id): + found_task = validate_task_id(task_id) + + found_task.completed_at = None + + db.session.commit() + + return {"task": + {"id": found_task.task_id, + "title": found_task.title, + "description": found_task.description, + "is_complete": bool(found_task.completed_at)}}, 200 + + +@tasks_bp.route("/", methods=["DELETE"]) +def delete_task(task_id): + found_task = validate_task_id(task_id) + + db.session.delete(found_task) + db.session.commit() + + return jsonify({"details": f'Task {found_task.task_id} "{found_task.title}" successfully deleted'}) diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/35aeac1d176b_.py b/migrations/versions/35aeac1d176b_.py new file mode 100644 index 000000000..04d86c82e --- /dev/null +++ b/migrations/versions/35aeac1d176b_.py @@ -0,0 +1,39 @@ +"""empty message + +Revision ID: 35aeac1d176b +Revises: +Create Date: 2022-05-05 14:15:22.861253 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '35aeac1d176b' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), nullable=False), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/a8259b633e3b_.py b/migrations/versions/a8259b633e3b_.py new file mode 100644 index 000000000..e5c01e482 --- /dev/null +++ b/migrations/versions/a8259b633e3b_.py @@ -0,0 +1,28 @@ +"""empty message + +Revision ID: a8259b633e3b +Revises: 35aeac1d176b +Create Date: 2022-05-10 20:01:57.916962 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'a8259b633e3b' +down_revision = '35aeac1d176b' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('goal', sa.Column('title', sa.String(), nullable=True)) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('goal', 'title') + # ### end Alembic commands ### diff --git a/migrations/versions/bb61f83efb58_.py b/migrations/versions/bb61f83efb58_.py new file mode 100644 index 000000000..fa495b116 --- /dev/null +++ b/migrations/versions/bb61f83efb58_.py @@ -0,0 +1,30 @@ +"""empty message + +Revision ID: bb61f83efb58 +Revises: fc6b958c09c9 +Create Date: 2022-05-13 09:27:56.135098 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'bb61f83efb58' +down_revision = 'fc6b958c09c9' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['goal_id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### diff --git a/migrations/versions/fc6b958c09c9_.py b/migrations/versions/fc6b958c09c9_.py new file mode 100644 index 000000000..adcc43c60 --- /dev/null +++ b/migrations/versions/fc6b958c09c9_.py @@ -0,0 +1,38 @@ +"""empty message + +Revision ID: fc6b958c09c9 +Revises: a8259b633e3b +Create Date: 2022-05-12 10:16:36.397857 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'fc6b958c09c9' +down_revision = 'a8259b633e3b' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('goal', sa.Column('id', sa.Integer(), autoincrement=True, nullable=False)) + op.drop_column('goal', 'goal_id') + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.add_column('task', sa.Column('id', sa.Integer(), autoincrement=True, nullable=False)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['id']) + op.drop_column('task', 'task_id') + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('task_id', sa.INTEGER(), autoincrement=True, nullable=False)) + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'id') + op.drop_column('task', 'goal_id') + op.add_column('goal', sa.Column('goal_id', sa.INTEGER(), autoincrement=True, nullable=False)) + op.drop_column('goal', 'id') + # ### end Alembic commands ### diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..a38a94219 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -59,14 +59,11 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": f"Task 1 not found"} - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,12 +90,12 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ "title": "Updated Task Title", - "description": "Updated Test Description", + "description": "Updated Test Description" }) response_body = response.get_json() @@ -119,7 +116,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -130,14 +127,11 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": f"Task 1 not found"} - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +146,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -160,16 +154,13 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert "message" in response_body + assert response_body == {"message": f"Task 1 not found"} assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +177,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 959176ceb..13c5ab873 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +127,11 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": f"Task 1 not found"} - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,16 +139,13 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert "message" in response_body + assert response_body == {"message": f"Task 1 not found"} # Let's add this test for creating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_with_valid_completed_at(client): # Act response = client.post("/tasks", json={ @@ -179,9 +173,7 @@ def test_create_task_with_valid_completed_at(client): assert new_task.completed_at -# Let's add this test for updating tasks, now that -# the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_with_completed_at_date(client, completed_task): # Act response = client.put("/tasks/1", json={ diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..964b6d03c 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ import pytest +from app.models.goal import Goal -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +13,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +30,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +47,20 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): - pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") # Assert - # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Test ---- + + assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": f"Goal 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +79,37 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title"}) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 200 + # assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title"}} + goal = Goal.query.get(1) + assert goal.title == "Updated Goal Title" -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- - + # raise Exception("Complete test") + response = client.put("/goals/1", json={ + "title": "Updated Goal Title"}) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": f"Goal 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -123,28 +125,24 @@ def test_delete_goal(client, one_goal): # Check that the goal was deleted response = client.get("/goals/1") assert response.status_code == 404 + assert Goal.query.get(1) == None - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert "message" in response_body + assert response_body == {"message": f"Goal 1 not found"} + + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..b32ad5bc9 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -51,13 +51,8 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +69,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +94,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()