diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..066ed31d9 --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..aaa466765 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -22,13 +22,18 @@ def create_app(test_config=None): app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( "SQLALCHEMY_TEST_DATABASE_URI") - # Import models here for Alembic setup + # Import models for Alembic setup from app.models.task import Task from app.models.goal import Goal db.init_app(app) migrate.init_app(app, db) - # Register Blueprints here + # Register Blueprints + from .task_routes import task_bp + from .goal_routes import goal_bp + + app.register_blueprint(task_bp) + app.register_blueprint(goal_bp) return app diff --git a/app/external/__init__.py b/app/external/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/app/external/slack.py b/app/external/slack.py new file mode 100644 index 000000000..81a285d6a --- /dev/null +++ b/app/external/slack.py @@ -0,0 +1,16 @@ +import os +import requests + +TOKEN = os.environ.get("SLACK_BOT_TOKEN") + +def notify_completed(task_title): + data = { + "channel": "test-channel", + "text": f"Someone just completed the task {task_title}" + } + + headers = { + "Authorization": f"Bearer {TOKEN}" + } + + requests.post('https://slack.com/api/chat.postMessage', data = data, headers = headers) diff --git a/app/goal_routes.py b/app/goal_routes.py new file mode 100644 index 000000000..55f0bbb5d --- /dev/null +++ b/app/goal_routes.py @@ -0,0 +1,129 @@ +from flask import Blueprint, jsonify, make_response, abort, request +from app.models.goal import Goal +from app.models.task import Task +from app import db + +goal_bp = Blueprint("goal_bp", __name__, url_prefix="/goals") + +#Create goal +@goal_bp.route("", methods=["POST"]) +def create_goal(): + request_body = request.get_json() + + try: + title = request_body['title'] + except KeyError: + return abort(make_response({"details": 'Invalid data'}, 400)) + + new_goal = Goal( + title = title, + ) + + db.session.add(new_goal) + db.session.commit() + + response = { + "goal": new_goal.to_dict() + } + + return make_response(response, 201) + + +#Get all goals or no saved goals +@goal_bp.route("", methods=["GET"]) +def get_goals(): + goals = Goal.query.all() + + goals_response = [] + for goal in goals: + goals_response.append(goal.to_dict()) + + return make_response(jsonify(goals_response), 200) + +#Get One Goal: One Saved Goal +@goal_bp.route("/", methods=["GET"]) +def read_one_goal(goal_id): + goal = Goal.query.get(goal_id) + + if not goal: + return abort(make_response({"message": f"Goal {goal_id} is not found"}, 404)) + + response = { + "goal": goal.to_dict() + } + + return response + +#Update one goal +@goal_bp.route("/", methods = ["PUT"]) +def update_one_goals(goal_id): + goal = Goal.query.get(goal_id) + + if not goal: + return abort(make_response({"message": f"Goal {goal_id} is not found"}, 404)) + + request_body = request.get_json() + + goal.title = request_body['title'] + + db.session.commit() + + return make_response({"goal": goal.to_dict()}, 200) + +#Delete Goal: Deleting a Goal +@goal_bp.route("/", methods = ["DELETE"]) +def delete_one_goal(goal_id): + goal = Goal.query.get(goal_id) + + if not goal: + return abort(make_response({"message": f"Goal {goal_id} is not found"}, 404)) + + db.session.delete(goal) + db.session.commit() + + response = { + 'details': f'Goal {goal.goal_id} "{goal.title}" successfully deleted' + } + + return make_response(response, 200) + +@goal_bp.route("//tasks", methods = ["POST"]) +def add_tasks(goal_id): + request_body = request.get_json() + task_ids = request_body['task_ids'] + + for task_id in task_ids: + task = Task.query.get(task_id) + if not task: + return abort(make_response({"message": f"Task {task_id} is not found"}, 404)) + + task.goal_id = goal_id + + db.session.commit() + + response_body = { + "id": int(goal_id), + "task_ids": task_ids + } + + return make_response(response_body, 200) + +@goal_bp.route("//tasks", methods=["GET"]) +def read_tasks(goal_id): + goal = Goal.query.get(goal_id) + + if not goal: + return abort(make_response({"message": f"Goal {goal_id} is not found"}, 404)) + + + tasks = [] + for task in goal.tasks: + tasks.append(task.to_dict()) + + response_body = { + "id": int(goal_id), + "title": goal.title, + "tasks": tasks + } + + return make_response(response_body, 200) \ No newline at end of file diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..05a036995 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,12 @@ from app import db - class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + goal_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String, nullable=False) + tasks = db.relationship("Task", back_populates="goal", lazy=True) + + def to_dict(self): + return { + "id": self.goal_id, + "title": self.title, + } \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..4da569b3e 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,25 @@ from app import db - +''' +Task is a todo list task +''' class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + task_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String, nullable=False) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, nullable=True) + goal_id = db.Column(db.Integer, db.ForeignKey('goal.goal_id'), nullable=True) + goal = db.relationship("Goal", back_populates="tasks") + + def to_dict(self): + d = { + "id": self.task_id, + "title": self.title, + "description": self.description, + "is_complete": True if self.completed_at else False + } + + if self.goal_id: + d['goal_id'] = self.goal_id + + return d \ No newline at end of file diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 3aae38d49..000000000 --- a/app/routes.py +++ /dev/null @@ -1 +0,0 @@ -from flask import Blueprint \ No newline at end of file diff --git a/app/task_routes.py b/app/task_routes.py new file mode 100644 index 000000000..f316bc4bb --- /dev/null +++ b/app/task_routes.py @@ -0,0 +1,134 @@ +from flask import Blueprint, jsonify, make_response, abort, request +from app.models.task import Task +from app import db +from datetime import datetime +from app.external import slack + +task_bp = Blueprint("task_bp", __name__, url_prefix="/tasks") + +#Create task +@task_bp.route("", methods=["POST"]) +def create_task(): + request_body = request.get_json() + + try: + title = request_body['title'] + description = request_body['description'] + except KeyError: + return abort(make_response({"details": 'Invalid data'}, 400)) + + new_task = Task( + title = title, + description = description, + completed_at = request_body.get("completed_at") + ) + + db.session.add(new_task) + db.session.commit() + + response = { + "task": new_task.to_dict() + } + + return make_response(response, 201) + + +#Get all tasks or no saved tasks +@task_bp.route("", methods=["GET"]) +def get_tasks(): + + sort_query = request.args.get("sort") + if sort_query == "asc": + tasks = Task.query.order_by(Task.title.asc()).all() + elif sort_query == "desc": + tasks = Task.query.order_by(Task.title.desc()).all() + else: + tasks = Task.query.all() + + + tasks_response = [] + for task in tasks: + tasks_response.append(task.to_dict()) + + return make_response(jsonify(tasks_response), 200) + +#Get One Task: One Saved Task +@task_bp.route("/", methods=["GET"]) +def read_one_task(task_id): + task = Task.query.get(task_id) + + if not task: + return abort(make_response({"message": f"Task {task_id} is not found"}, 404)) + + response = { + "task": task.to_dict() + } + + return response + +#Update one task +@task_bp.route("/", methods = ["PUT"]) +def update_one_tasks(task_id): + task = Task.query.get(task_id) + + if not task: + return abort(make_response({"message": f"Task {task_id} is not found"}, 404)) + + request_body = request.get_json() + + task.title = request_body['title'] + task.description = request_body['description'] + + if 'completed_at' in request_body: + task.completed_at = request_body['completed_at'] + + db.session.commit() + + return make_response({"task": task.to_dict()}, 200) + +#Delete Task: Deleting a Task +@task_bp.route("/", methods = ["DELETE"]) +def delete_one_task(task_id): + task = Task.query.get(task_id) + + if not task: + return abort(make_response({"message": f"Task {task_id} is not found"}, 404)) + + db.session.delete(task) + db.session.commit() + + response = { + 'details': f'Task {task.task_id} "{task.title}" successfully deleted' + } + + return make_response(response, 200) + +@task_bp.route("//mark_complete", methods = ["PATCH"]) +def mark_complete(task_id): + task = Task.query.get(task_id) + + if not task: + return abort(make_response({"message": f"Task {task_id} is not found"}, 404)) + + task.completed_at = datetime.now() + db.session.commit() + + slack.notify_completed(task.title) + + return make_response({ + "task": task.to_dict() + }, 200) + +@task_bp.route("//mark_incomplete", methods = ["PATCH"]) +def mark_incomplete(task_id): + task = Task.query.get(task_id) + + if not task: + return abort(make_response({"message": f"Task {task_id} is not found"}, 404)) + + task.completed_at = None + db.session.commit() + + return make_response({ + "task": task.to_dict() + }, 200) diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/9b4b8d3a900d_add_goal_relationship.py b/migrations/versions/9b4b8d3a900d_add_goal_relationship.py new file mode 100644 index 000000000..2fc3e7997 --- /dev/null +++ b/migrations/versions/9b4b8d3a900d_add_goal_relationship.py @@ -0,0 +1,30 @@ +"""add goal relationship + +Revision ID: 9b4b8d3a900d +Revises: e4a9662948d8 +Create Date: 2022-05-11 08:12:39.171039 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '9b4b8d3a900d' +down_revision = 'e4a9662948d8' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['goal_id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### diff --git a/migrations/versions/b1ee6e7dfdea_.py b/migrations/versions/b1ee6e7dfdea_.py new file mode 100644 index 000000000..cce441015 --- /dev/null +++ b/migrations/versions/b1ee6e7dfdea_.py @@ -0,0 +1,39 @@ +"""empty message + +Revision ID: b1ee6e7dfdea +Revises: +Create Date: 2022-05-06 22:58:33.626489 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'b1ee6e7dfdea' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), nullable=False), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/e4a9662948d8_.py b/migrations/versions/e4a9662948d8_.py new file mode 100644 index 000000000..b4d4181d2 --- /dev/null +++ b/migrations/versions/e4a9662948d8_.py @@ -0,0 +1,28 @@ +"""empty message + +Revision ID: e4a9662948d8 +Revises: b1ee6e7dfdea +Create Date: 2022-05-11 07:50:29.786072 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'e4a9662948d8' +down_revision = 'b1ee6e7dfdea' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('goal', sa.Column('title', sa.String(), nullable=False)) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('goal', 'title') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 30ff414fe..55059af01 100644 --- a/requirements.txt +++ b/requirements.txt @@ -4,7 +4,9 @@ autopep8==1.5.5 blinker==1.4 certifi==2020.12.5 chardet==4.0.0 +charset-normalizer==2.0.12 click==7.1.2 +coverage==6.3.2 Flask==1.1.2 Flask-Migrate==2.6.0 Flask-SQLAlchemy==2.4.4 @@ -32,3 +34,4 @@ SQLAlchemy==1.3.23 toml==0.10.2 urllib3==1.26.5 Werkzeug==1.0.1 +wonderwords==2.2.0 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..3f41e0869 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -59,14 +59,15 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {'message': 'Task 1 is not found'} + - raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +94,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +120,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -131,13 +132,14 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {'message': 'Task 1 is not found'} -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +154,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -161,15 +163,16 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + #raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {'message': 'Task 1 is not found'} assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +189,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..c9a76e6b1 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 959176ceb..4f57793f5 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,12 +42,12 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") response_body = response.get_json() - +# # Assert assert response.status_code == 200 assert response_body["task"]["is_complete"] == False @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -128,13 +128,14 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {'message': 'Task 1 is not found'} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -143,15 +144,16 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {'message': 'Task 1 is not found'} # Let's add this test for creating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_with_valid_completed_at(client): # Act response = client.post("/tasks", json={ @@ -181,8 +183,8 @@ def test_create_task_with_valid_completed_at(client): # Let's add this test for updating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") -def test_update_task_with_completed_at_date(client, completed_task): +# @pytest.mark.skip(reason="No way to test this feature yet") +def test_update_task_with_completed_at_date(client, one_task): # Act response = client.put("/tasks/1", json={ "title": "Updated Task Title", diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..dcc516a2e 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,7 @@ import pytest +from app.models.goal import Goal - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +12,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +29,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +46,26 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + # raise Exception("Complete test") # Assert # ---- Complete Test ---- # assertion 1 goes here # assertion 2 goes here + assert response.status_code == 404 + assert response_body == {'message': 'Goal 1 is not found'} + # ---- Complete Test ---- -@pytest.mark.skip(reason="No way to test this feature yet") + +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +84,43 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title", + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title", + } + } + + goal = Goal.query.get(1) + assert goal.title == "Updated Goal Title" + -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title", + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == {'message': 'Goal 1 is not found'} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -124,27 +137,32 @@ def test_delete_goal(client, one_goal): response = client.get("/goals/1") assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response.get_json() == {"message": "Goal 1 is not found"} -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + + #raise Exception("Complete test with assertion about response body") + # ***************************************************************** + # **Complete test with assertion about response body*************** + # ***************************************************************** + assert response_body == {'message': 'Goal 1 is not found'} + + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..0dafd541f 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -41,8 +41,20 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on } assert len(Goal.query.get(1).tasks) == 2 +# check post task id , task not found, 404 +def test_post_task_ids_to_goal_without_a_task(client, one_goal, three_tasks): + # Act + response = client.post("/goals/1/tasks", json={ + "task_ids": [13] + }) + response_body = response.get_json() + + # Assert + assert response.status_code == 404 + assert response_body == {'message': 'Task 13 is not found'} + assert len(Goal.query.get(1).tasks) == 0 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -51,13 +63,14 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {'message': 'Goal 1 is not found'} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +87,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +112,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()