Skip to content

Commit 03735ff

Browse files
committed
libbtrfs: reduce rbtree includes and ship only rbtree_types.h
None of the public API uses the rb-tree code besides definitions, so change the includes in ctree.h and drop rbtree.h, this is used only by internal implementation in send-utils.c. We could remove it in the future but last time it was not possible due to 3rd party code depending on it. Removed in 83ab925 ("libbtrfs: remove the support for fs without uuid tree") and reverted again in f9b0da8 ("Revert "libbtrfs: remove the support for fs without uuid tree"") Signed-off-by: David Sterba <[email protected]>
1 parent 674b50c commit 03735ff

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ libbtrfs_objects = \
269269
libbtrfs/send-utils.o \
270270
libbtrfs/crc32c.o
271271

272-
libbtrfs_headers = libbtrfs/send-stream.h libbtrfs/send-utils.h libbtrfs/send.h kernel-lib/rbtree.h \
272+
libbtrfs_headers = libbtrfs/send-stream.h libbtrfs/send-utils.h libbtrfs/send.h \
273273
kernel-lib/rbtree_types.h libbtrfs/kerncompat.h \
274274
libbtrfs/ioctl.h libbtrfs/ctree.h libbtrfs/version.h
275275
libbtrfs_version = $(LIBBTRFS_MAJOR).$(LIBBTRFS_MINOR).$(LIBBTRFS_PATCHLEVEL)

libbtrfs/ctree.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323

2424
#if BTRFS_FLAT_INCLUDES
2525
#include "libbtrfs/kerncompat.h"
26-
#include "kernel-lib/rbtree.h"
26+
#include "kernel-lib/rbtree_types.h"
2727
#include "libbtrfs/ioctl.h"
2828
#else
2929
#include <btrfs/kerncompat.h>
30-
#include <btrfs/rbtree.h>
30+
#include <btrfs/rbtree_types.h>
3131
#include <btrfs/ioctl.h>
3232
#endif /* BTRFS_FLAT_INCLUDES */
3333

tests/library-test.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "libbtrfs/kerncompat.h"
2121
#include "libbtrfs/version.h"
2222
#include "libbtrfs/ioctl.h"
23-
#include "kernel-lib/rbtree.h"
23+
#include "kernel-lib/rbtree_types.h"
2424
#include "kernel-shared/ctree.h"
2525
#include "kernel-shared/send.h"
2626
#include "common/send-stream.h"
@@ -32,7 +32,7 @@
3232
*/
3333
#include "btrfs/kerncompat.h"
3434
#include "btrfs/version.h"
35-
#include "btrfs/rbtree.h"
35+
#include "btrfs/rbtree_types.h"
3636
#include "btrfs/ctree.h"
3737
#include "btrfs/ioctl.h"
3838
#include "btrfs/send.h"

0 commit comments

Comments
 (0)