From c227f94410fb04693e9b2f8b3c58dda60f2d36bc Mon Sep 17 00:00:00 2001 From: Adam Narozniak <51029327+adam-narozniak@users.noreply.github.com> Date: Fri, 13 Dec 2024 13:56:32 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Javier --- .../partitioner/vertical_size_partitioner.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/datasets/flwr_datasets/partitioner/vertical_size_partitioner.py b/datasets/flwr_datasets/partitioner/vertical_size_partitioner.py index ba847963d994..f321be673ed0 100644 --- a/datasets/flwr_datasets/partitioner/vertical_size_partitioner.py +++ b/datasets/flwr_datasets/partitioner/vertical_size_partitioner.py @@ -198,20 +198,20 @@ def _validate_parameters_in_init(self) -> None: if all(isinstance(fraction, float) for fraction in self._partition_sizes): fraction_sum = sum(self._partition_sizes) if fraction_sum != 1.0: - raise ValueError("Float ratios in column_distribution must sum to 1.0.") + raise ValueError("Float ratios in `partition_sizes` must sum to 1.0.") if any( fraction < 0.0 or fraction > 1.0 for fraction in self._partition_sizes ): raise ValueError( - "All floats in column_distribution must be >= 0.0 and <= 1.0." + "All floats in `partition_sizes` must be >= 0.0 and <= 1.0." ) elif all( isinstance(coulumn_count, int) for coulumn_count in self._partition_sizes ): if any(coulumn_count < 0 for coulumn_count in self._partition_sizes): - raise ValueError("All integers in column_distribution must be >= 0.") + raise ValueError("All integers in `partition_sizes` must be >= 0.") else: - raise ValueError("partition_sizes list must be all floats or all ints.") + raise ValueError("`partition_sizes` list must be all floats or all ints.") # Validate columns lists for parameter_name, parameter_list in [