-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InnerDirichletPartitioner #2794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments
datasets/flwr_datasets/partitioner/inner_dirichlet_partitioner.py
Outdated
Show resolved
Hide resolved
datasets/flwr_datasets/partitioner/inner_dirichlet_partitioner.py
Outdated
Show resolved
Hide resolved
datasets/flwr_datasets/partitioner/inner_dirichlet_partitioner.py
Outdated
Show resolved
Hide resolved
* Track exhausted nodes * Adjust the probabilities once there are no more samples from class k
jafermarq
reviewed
Mar 4, 2024
datasets/flwr_datasets/partitioner/inner_dirichlet_partitioner.py
Outdated
Show resolved
Hide resolved
jafermarq
approved these changes
Mar 4, 2024
danieljanes
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Add Inner Dirichlet Partitioner based on Federated Learning Based on Dynamic Regularization https://arxiv.org/abs/2111.04263.
Explanation
This variation of Dirchlet-based partitioning differs from the #2795.
This implementation does the following:
partition_sizes
and required to be provided by a user.How does it differ from the original Dirichlet from #2795?
This implementation is used to choose to divide classes among partitions. The Dirichlet distribution is drawn such that the class
n
is split amongp
partitions. This is repeatedN
(number of unique classes) times. Therefore, there's no need to decide on the size of each partition in the original Dirichlet.Also, what might help to understand the difference is to think about the shape of the alpha value (concentration) for the Dirichlet.
Original: size is equal to the number of partitions (and is repeated the number of unique classes)
This implementation: size equals the number of unique classes (and is repeated the number of partitions).
Note that it also means that at a certain point in this implementation, we run out of the samples from class
n
while sampling for later partitions, and the code needs to be adjusted for that (to give other samples in that case).