Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partition division #2951

Merged
merged 21 commits into from
Mar 11, 2024
Merged

Add partition division #2951

merged 21 commits into from
Mar 11, 2024

Conversation

adam-narozniak
Copy link
Contributor

@adam-narozniak adam-narozniak commented Feb 14, 2024

Issue

After calling the fds.load_partitition, you often need to divide the data for e.g. train and eval. That adds manual labor that can be avoided.

Proposal

Add a new parameter to FederatedDataset that dictates how you want the data divided directly when calling load_partition; see partition_division.

At the same time, expose the divide_dataset function so that a user can also do it manually himself.

Changelog

@adam-narozniak adam-narozniak marked this pull request as ready for review February 16, 2024 09:20
@adam-narozniak adam-narozniak self-assigned this Feb 27, 2024
jafermarq
jafermarq previously approved these changes Mar 5, 2024
@danieljanes danieljanes enabled auto-merge (squash) March 11, 2024 20:50
@danieljanes danieljanes merged commit 0864aa7 into main Mar 11, 2024
34 checks passed
@danieljanes danieljanes deleted the fds-add-partition-splitting branch March 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants