Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flwr run to command line interface #3049

Merged
merged 25 commits into from
Mar 6, 2024
Merged

Add flwr run to command line interface #3049

merged 25 commits into from
Mar 6, 2024

Conversation

tanertopal
Copy link
Member

@tanertopal tanertopal commented Mar 2, 2024 •
edited
Loading

Issue

Description

This PR introduces a new Flower CLI command run enabling the execution of a Flower project with a single command.

After #3059 is merged simply do the following:

flwr new --framework numpy fedmin
cd fedmin
flwr run

Related issues/PRs

The first compatible project can be generated after merging #3059

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

@tanertopal tanertopal self-assigned this Mar 2, 2024
Moep90
Moep90 reviewed Mar 4, 2024
View reviewed changes
@tanertopal tanertopal marked this pull request as ready for review March 5, 2024 17:29
@tanertopal tanertopal requested a review from danieljanes as a code owner March 5, 2024 17:29
danieljanes
danieljanes reviewed Mar 5, 2024
View reviewed changes
jafermarq
jafermarq reviewed Mar 5, 2024
View reviewed changes
tanertopal and others added 12 commits March 5, 2024 21:32
@tanertopal @danieljanes
Update src/py/flwr/cli/flower_toml.py
204ebbf 
Co-authored-by: Daniel J. Beutel <[email protected]>
@tanertopal @danieljanes
Update src/py/flwr/cli/flower_toml.py
cb70213 
Co-authored-by: Daniel J. Beutel <[email protected]>
@tanertopal @danieljanes
Update src/py/flwr/cli/flower_toml_test.py
5efccf9 
Co-authored-by: Daniel J. Beutel <[email protected]>
@tanertopal @danieljanes
Update src/py/flwr/cli/run/run.py
acf5eab 
Co-authored-by: Daniel J. Beutel <[email protected]>
@tanertopal @jafermarq
Update pyproject.toml
7745472 
Co-authored-by: Javier <[email protected]>
@tanertopal
Remove empty file
17f3f5d
@tanertopal
Merge branch 'flwr_run' of github.com:adap/flower into flwr_run
44c0098 
* 'flwr_run' of github.com:adap/flower:
  Update pyproject.toml
  Update src/py/flwr/cli/run/run.py
  Update src/py/flwr/cli/flower_toml_test.py
  Update src/py/flwr/cli/flower_toml.py
  Update src/py/flwr/cli/flower_toml.py
@tanertopal
Merge branch 'main' into flwr_run
215026c
@tanertopal
Fix
81e1c7b
@tanertopal
Merge branch 'flwr_run' of github.com:adap/flower into flwr_run
eed48f5 
* 'flwr_run' of github.com:adap/flower:
  Add `LegacyMessageType` (#3064)
  Add `MessageType` (#3005)
  Add Flower Client App connection error handling (#2969)
  Refactor `app_dir` arguments (#3061)
  Add InnerDirichletPartitioner (#2794)
  Add NumPy template to new command (#3059)
@tanertopal
Merge branch 'main' into flwr_run
a3761f9
@tanertopal
Add loading comments to ensure the users knows when waiting is expected
968d2ce
@tanertopal
Merge branch 'flwr_run' of github.com:adap/flower into flwr_run
bbc54e6 
* 'flwr_run' of github.com:adap/flower:
  Add `ViT` example (#3063)
  Remove `MESSAGE_TYPE_*` (#3065)
@danieljanes danieljanes merged commit 2118cea into main Mar 6, 2024
28 checks passed
@danieljanes danieljanes deleted the flwr_run branch March 6, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moep90 Moep90 Moep90 left review comments

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes danieljanes approved these changes

Assignees

@tanertopal tanertopal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanertopal @danieljanes @Moep90 @jafermarq