Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fds add concatenate divisions #3103

Merged
merged 37 commits into from
Mar 14, 2024
Merged

Fds add concatenate divisions #3103

merged 37 commits into from
Mar 14, 2024

Conversation

adam-narozniak
Copy link
Contributor

@adam-narozniak adam-narozniak commented Mar 11, 2024 •
edited
Loading

Issue

There's no clean way to accomplish concatenate division e.g. for centralized dataset.
The partition_division in the FederatedDataset is not a clean solution (it adds too much complexity).

Proposal

Add concatenate division as an external function.
Remove the partition_division from FederatedDataset.

Changelog entry

adam-narozniak and others added 24 commits February 14, 2024 16:22
@adam-narozniak
Add partition_division to FederatedDataset
507065b
@adam-narozniak
wip: partition division utils
6707839
@adam-narozniak
Update load_partition
9f4b310
@adam-narozniak
Update divsion utils
876dad5
@adam-narozniak
Update tests
1e77c06
@adam-narozniak
Remove inner_split keyword from load_partition
ecf2b40
@adam-narozniak
Expose utils module
d08b44b
@adam-narozniak
Expose utils module
0ed7585
@adam-narozniak
Add an example to FDS docs
494fdeb
@adam-narozniak @jafermarq
Update datasets/flwr_datasets/utils.py
2777491 
Co-authored-by: Javier <[email protected]>
@adam-narozniak
Remove redundant computation
7c74123
@adam-narozniak
Merge remote-tracking branch 'origin/fds-add-partition-splitting' int…
ecef48b 
…o fds-add-partition-splitting
@adam-narozniak
Add an example to divide_dataset function
57c7c63
@adam-narozniak
Add a second example to divide_dataset fnc
6486c8a
@adam-narozniak
Fix load_partition docs
a8b0bfd
@adam-narozniak
Update year in the Copyright notice
6052e2a
@danieljanes
Merge branch 'main' into fds-add-partition-splitting
5f13155
@adam-narozniak @danieljanes
Apply suggestions from code review
497a5cc 
Co-authored-by: Daniel J. Beutel <[email protected]>
@adam-narozniak
Fix return type docs
f0a906e
@adam-narozniak
Support partitioner-specific partition_division
4a4de26
@adam-narozniak
Add num_partition property
4211941
@adam-narozniak
Trigger the partitioning in the num_partitions
02411f7
@adam-narozniak
Merge branch 'fds-add-num-partitions' into fds-add-concatenate-divisions
ebc486b
@adam-narozniak
Add concatenate_divisions
d651c10
jafermarq
jafermarq reviewed Mar 13, 2024
View reviewed changes
@adam-narozniak adam-narozniak marked this pull request as draft March 13, 2024 22:58
@adam-narozniak adam-narozniak marked this pull request as ready for review March 14, 2024 00:07
@adam-narozniak adam-narozniak mentioned this pull request Mar 14, 2024
Merged
jafermarq
jafermarq reviewed Mar 14, 2024
View reviewed changes
@jafermarq jafermarq enabled auto-merge (squash) March 14, 2024 09:42
@jafermarq jafermarq disabled auto-merge March 14, 2024 09:51
@jafermarq jafermarq enabled auto-merge (squash) March 14, 2024 09:52
@jafermarq jafermarq merged commit f2199aa into main Mar 14, 2024
34 checks passed
@jafermarq jafermarq deleted the fds-add-concatenate-divisions branch March 14, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam-narozniak @jafermarq @danieljanes