refactor(datasets) Make naming consistent in VerticalSizePartitioner #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adam-narozniak
commented
Dec 19, 2024
•
adam-narozniak
commented
- column modification params in plural
- same argument types here and in VerticalEvenPartitioner
- update incorrect docs hint types for VerticalEven and VerticalSizePartitioner
- handle case when the fractions (floats) don't sum up smoothly to 1.0 but are close
adam-narozniak
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
jafermarq
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.