-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(baselines) Upgrade FedProx Baselne to new flwr format #4937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @maddox-j , this looks pretty good!! I added a few minor comments below.
I was able to run all the experiments running your script but then it seems the notebook ins't creating the plots. I believe some parts need (maybe just the process_data()
function) adjustments since the results structure is different since we aren't using Hydra's --multirun
anymore.
@jafermarq Thanks for all the comments. I have resolved your comments in one commit so that we keep the history a bit neater. With reference to the notebook: I did make these function changes initially. I added a fixed path to the results in the notebook now in case this was the error. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maddox-j , great to see FedProx
running via flwr run
🚀
Issue
Description
This PR upgrades the existing
FedProx
baseline from the previousflwr
format to the new version.Specifically:
flwr-datasets
withDistributionPartitioner
instead of manual handling.Server
class definition.Related issues/PRs
N/A
Proposal
Explanation
This makes the
FedProx
baseline consistent with the currentflwr
version.Checklist
#contributions
)Any other comments?
N/A