Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No studio icons on folders and episodes (Estuary skin) #250

Open
dagwieers opened this issue May 17, 2019 · 3 comments · Fixed by xbmc/xbmc#16298
Open

No studio icons on folders and episodes (Estuary skin) #250

dagwieers opened this issue May 17, 2019 · 3 comments · Fixed by xbmc/xbmc#16298
Labels
enhancement New feature or request estuary Related to Kodi's default skin kodi Related to the Kodi media player released A fix for this issue has been released by upstream

Comments

@dagwieers
Copy link
Collaborator

dagwieers commented May 17, 2019 •
edited
Loading

Describe the bug

The Estuary skin (the default Kodi skin) does not support studio icons on folders.

We discovered Kodi's studio icon support only by accident because we used mediatype infolabels on 'tvshows' folders (causing these folders to not show as folders). Now that we have fixed that, we lost studio icons on our program listings...

Additionally, in episode-listings we also do not see any studio icons, while there is no reason to not show them.

It would be nice if:

  1. studio icons are shown for folders too (folders can't have a mediatype according to Kodi)
  2. studio icons are shown on episodes (not just tvshows)
  3. mediatype infolabels are allowed on folders (not a skin issue)

The fix in phil65/skin.estuary#258 even supports studio icons now in our Most recent, Channels and Live TV listitems. Which is really great.
@dagwieers dagwieers added the enhancement New feature or request label May 17, 2019
@dagwieers dagwieers added this to the Future milestone May 17, 2019
@dagwieers dagwieers added the help wanted Extra attention is needed label May 17, 2019
@dagwieers dagwieers mentioned this issue May 17, 2019
Closed
@dagwieers dagwieers removed the help wanted Extra attention is needed label May 18, 2019
@dagwieers dagwieers changed the title Estuary skin does not support studio icons on folders No studio icons on folders and episodes (Estuary skin) May 19, 2019
@dagwieers
Copy link
Collaborator Author

Fixed in phil65/skin.estuary#258, however Estuary hasn't seen any updates for a long time. I wonder if it is still maintained.

@dagwieers dagwieers added the kodi Related to the Kodi media player label May 21, 2019
@dagwieers dagwieers mentioned this issue Jun 24, 2019
Merged
13 tasks
@dagwieers
Copy link
Collaborator Author

Apparently the Estuary skin is no longer maintained at phil65/skin.esuary#258 but instead maintained upstream at xbmc/xbmc#16298

@dagwieers dagwieers removed this from the Future milestone Jun 26, 2019
@dagwieers dagwieers added the fixed An upstream fix is available but not yet released label Jul 5, 2019
@dagwieers dagwieers added the estuary Related to Kodi's default skin label Jul 26, 2019
@dagwieers
Copy link
Collaborator Author

dagwieers commented Oct 8, 2019 •
edited
Loading

The fix has been merged and will be released as port of Kodi v19.

@dagwieers dagwieers added merged A fix for this issue has been merged by upstream and removed fixed An upstream fix is available but not yet released labels Mar 20, 2020
@dagwieers dagwieers reopened this Mar 20, 2020
@mediaminister mediaminister added released A fix for this issue has been released by upstream and removed merged A fix for this issue has been merged by upstream labels Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request estuary Related to Kodi's default skin kodi Related to the Kodi media player released A fix for this issue has been released by upstream
Projects
None yet
Milestone
No milestone
2 participants
@dagwieers @mediaminister