refactor: Remove unused command_type initialization in command executor classes

shima004 · shima004 · commit 4c933de821cb · 2024-12-18T02:08:44.000+09:00
diff --git a/adf_core_python/implement/centralized/default_command_executor_ambulance.py b/adf_core_python/implement/centralized/default_command_executor_ambulance.py
@@ -49,7 +49,6 @@ def __init__(
         super().__init__(
             agent_info, world_info, scenario_info, module_manager, develop_data
         )
-        self._command_type = self.ACTION_UNKNOWN
 
         self._path_planning: PathPlanning = cast(
             PathPlanning,
diff --git a/adf_core_python/implement/centralized/default_command_executor_fire.py b/adf_core_python/implement/centralized/default_command_executor_fire.py
@@ -46,7 +46,6 @@ def __init__(
         super().__init__(
             agent_info, world_info, scenario_info, module_manager, develop_data
         )
-        self._command_type = self.ACTION_UNKNOWN
 
         self._path_planning: PathPlanning = cast(
             PathPlanning,
diff --git a/adf_core_python/implement/centralized/default_command_executor_police.py b/adf_core_python/implement/centralized/default_command_executor_police.py
@@ -47,7 +47,6 @@ def __init__(
         super().__init__(
             agent_info, world_info, scenario_info, module_manager, develop_data
         )
-        self._command_type = self.ACTION_UNKNOWN
 
         self._path_planning: PathPlanning = cast(
             PathPlanning,
diff --git a/adf_core_python/implement/centralized/default_command_executor_scout.py b/adf_core_python/implement/centralized/default_command_executor_scout.py
@@ -41,7 +41,6 @@ def __init__(
         super().__init__(
             agent_info, world_info, scenario_info, module_manager, develop_data
         )
-        self._command_type = self.ACTION_UNKNOWN
 
         self._path_planning: PathPlanning = cast(
             PathPlanning,
diff --git a/adf_core_python/implement/centralized/default_command_executor_scout_police.py b/adf_core_python/implement/centralized/default_command_executor_scout_police.py
@@ -42,7 +42,6 @@ def __init__(
         super().__init__(
             agent_info, world_info, scenario_info, module_manager, develop_data
         )
-        self._command_type = self.ACTION_UNKNOWN
 
         self._path_planning: PathPlanning = cast(
             PathPlanning,
diff --git a/adf_core_python/implement/centralized/default_command_picker_ambulance.py b/adf_core_python/implement/centralized/default_command_picker_ambulance.py
@@ -61,6 +61,7 @@ def calculate(self) -> CommandPicker:
             if target is None:
                 continue
 
+            command: CommunicationMessage
             if isinstance(target, Human):
                 command = CommandAmbulance(
                     True,
diff --git a/adf_core_python/implement/centralized/default_command_picker_fire.py b/adf_core_python/implement/centralized/default_command_picker_fire.py
@@ -61,6 +61,7 @@ def calculate(self) -> CommandPicker:
             if target is None:
                 continue
 
+            command: CommunicationMessage
             if isinstance(target, Human):
                 command = CommandAmbulance(
                     True,
diff --git a/adf_core_python/implement/centralized/default_command_picker_police.py b/adf_core_python/implement/centralized/default_command_picker_police.py
@@ -1,19 +1,12 @@
 from __future__ import annotations
 
 from rcrs_core.entities.area import Area
-from rcrs_core.entities.human import Human
 from rcrs_core.entities.policeForce import PoliceForce
 from rcrs_core.worldmodel.entityID import EntityID
 
-from adf_core_python.core.agent.communication.standard.bundle.centralized.command_ambulance import (
-    CommandAmbulance,
-)
 from adf_core_python.core.agent.communication.standard.bundle.centralized.command_police import (
     CommandPolice,
 )
-from adf_core_python.core.agent.communication.standard.bundle.centralized.command_scout import (
-    CommandScout,
-)
 from adf_core_python.core.agent.communication.standard.bundle.standard_message_priority import (
     StandardMessagePriority,
 )

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,6 @@ def __init__(`
`49`	`49`	`super().__init__(`
`50`	`50`	`agent_info, world_info, scenario_info, module_manager, develop_data`
`51`	`51`	`)`
`52`		`- self._command_type = self.ACTION_UNKNOWN`
`53`	`52`
`54`	`53`	`self._path_planning: PathPlanning = cast(`
`55`	`54`	`PathPlanning,`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ def __init__(`
`46`	`46`	`super().__init__(`
`47`	`47`	`agent_info, world_info, scenario_info, module_manager, develop_data`
`48`	`48`	`)`
`49`		`- self._command_type = self.ACTION_UNKNOWN`
`50`	`49`
`51`	`50`	`self._path_planning: PathPlanning = cast(`
`52`	`51`	`PathPlanning,`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ def __init__(`
`47`	`47`	`super().__init__(`
`48`	`48`	`agent_info, world_info, scenario_info, module_manager, develop_data`
`49`	`49`	`)`
`50`		`- self._command_type = self.ACTION_UNKNOWN`
`51`	`50`
`52`	`51`	`self._path_planning: PathPlanning = cast(`
`53`	`52`	`PathPlanning,`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,6 @@ def __init__(`
`41`	`41`	`super().__init__(`
`42`	`42`	`agent_info, world_info, scenario_info, module_manager, develop_data`
`43`	`43`	`)`
`44`		`- self._command_type = self.ACTION_UNKNOWN`
`45`	`44`
`46`	`45`	`self._path_planning: PathPlanning = cast(`
`47`	`46`	`PathPlanning,`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,6 @@ def __init__(`
`42`	`42`	`super().__init__(`
`43`	`43`	`agent_info, world_info, scenario_info, module_manager, develop_data`
`44`	`44`	`)`
`45`		`- self._command_type = self.ACTION_UNKNOWN`
`46`	`45`
`47`	`46`	`self._path_planning: PathPlanning = cast(`
`48`	`47`	`PathPlanning,`