Parsing of new Response Data fields

Author: nonelse

Adjust/AIResponseData.h

@@ -45,6 +45,19 @@
 // tracker name of current device
 @property (nonatomic, copy) NSString *trackerName;
 
+// tracker network
+@property (nonatomic, copy) NSString *network;
+
+// tracker campaign
+@property (nonatomic, copy) NSString *campaign;
+
+// tracker adgroup
+@property (nonatomic, copy) NSString *adgroup;
+
+// tracker creative
+@property (nonatomic, copy) NSString *creative;
+
+
 // returns human readable version of activityKind
 // (session, event, revenue), see above
 - (NSString *)activityKindString;

Adjust/AIResponseData.m

@@ -34,6 +34,10 @@ - (id)initWithJsonString:(NSString *)jsonString {
     self.error        = [jsonDict objectForKey:@"error"];
     self.trackerToken = [jsonDict objectForKey:@"tracker_token"];
     self.trackerName  = [jsonDict objectForKey:@"tracker_name"];
+    self.network      = [jsonDict objectForKey:@"network"];
+    self.campaign     = [jsonDict objectForKey:@"campaign"];
+    self.adgroup      = [jsonDict objectForKey:@"adgroup"];
+    self.creative     = [jsonDict objectForKey:@"creative"];
 
     return self;
 }
@@ -53,13 +57,19 @@ - (NSString *)activityKindString {
 }
 
 - (NSString *)description {
-    return [NSString stringWithFormat:@"[kind:%@ success:%d willRetry:%d error:%@ trackerToken:%@ trackerName:%@]",
+    return [NSString stringWithFormat:@"[kind:%@ success:%d willRetry:%d "
+                                        "error:%@ trackerToken:%@ trackerName:%@ "
+                                        "network:%@ campaign:%@ adgroup:%@ creative:%@]",
             self.activityKindString,
             self.success,
             self.willRetry,
             self.error.aiQuote,
             self.trackerToken,
-            self.trackerName.aiQuote];
+            self.trackerName.aiQuote,
+            self.network.aiQuote,
+            self.campaign.aiQuote,
+            self.adgroup.aiQuote,
+            self.creative.aiQuote];
 }
 
 - (NSDictionary *)dictionary {
@@ -81,6 +91,22 @@ - (NSDictionary *)dictionary {
         [responseDataDic setObject:self.trackerName forKey:@"trackerName"];
     }
 
+    if (self.network != nil) {
+        [responseDataDic setObject:self.network forKey:@"network"];
+    }
+
+    if (self.campaign != nil) {
+        [responseDataDic setObject:self.campaign forKey:@"campaign"];
+    }
+
+    if (self.adgroup != nil) {
+        [responseDataDic setObject:self.adgroup forKey:@"adgroup"];
+    }
+
+    if (self.creative != nil) {
+        [responseDataDic setObject:self.creative forKey:@"creative"];
+    }
+
     return responseDataDic;
 }
 

AdjustTests/AIRequestHandlerTests.m

@@ -76,7 +76,8 @@ - (void)testSendPackage
 
     //  check the response data, the kind is unknown because is set by the package handler
     NSString *sresponseData= [NSString stringWithFormat:@"%@", self.packageHandlerMock.responseData];
-    XCTAssert([sresponseData isEqualToString:@"[kind:unknown success:1 willRetry:0 error:(null) trackerToken:token trackerName:name]"],
+    XCTAssert([sresponseData isEqualToString:@"[kind:unknown success:1 willRetry:0 error:(null) "
+               "trackerToken:token trackerName:name network:network campaign:campaign adgroup:adgroup creative:creative]"],
                    @"%@", sresponseData);
 
     //  check that the package was successfully sent
@@ -110,7 +111,8 @@ - (void)testConnectionError {
 
     //  check the response data,
     NSString *sresponseData= [NSString stringWithFormat:@"%@", self.packageHandlerMock.responseData];
-    XCTAssert([sresponseData isEqualToString:@"[kind:unknown success:0 willRetry:1 error:'connection error' trackerToken:(null) trackerName:(null)]"], @"%@", sresponseData);
+    XCTAssert([sresponseData isEqualToString:@"[kind:unknown success:0 willRetry:1 error:'connection error' "
+               "trackerToken:(null) trackerName:(null) network:(null) campaign:(null) adgroup:(null) creative:(null)]"], @"%@", sresponseData);
 
     //  check that the package was successfully sent
     XCTAssert([self.loggerMock containsMessage:AILogLevelError beginsWith:@"Failed to track session. (connection error) Will retry later."],
@@ -136,14 +138,15 @@ - (void)testResponseError {
     //  check the URL Connection was called
     XCTAssert([self.loggerMock containsMessage:AILogLevelTest beginsWith:@"NSURLConnection sendSynchronousRequest"],
               @"%@", self.loggerMock);
-
     //  check that the package handler was pinged after sending
     XCTAssert([self.loggerMock containsMessage:AILogLevelTest beginsWith:@"AIPackageHandler finishedTrackingActivity"],
               @"%@", self.loggerMock);
 
     //  check the response data,
     NSString *sresponseData= [NSString stringWithFormat:@"%@", self.packageHandlerMock.responseData];
-    XCTAssert([sresponseData isEqualToString:@"[kind:unknown success:0 willRetry:0 error:'response error' trackerToken:token trackerName:name]"], @"%@", sresponseData);
+
+    XCTAssert([sresponseData isEqualToString:@"[kind:unknown success:0 willRetry:0 error:'response error' "
+               "trackerToken:(null) trackerName:(null) network:(null) campaign:(null) adgroup:(null) creative:(null)]"], @"%@", sresponseData);
 
     //  check that the package was successfully sent
     XCTAssert([self.loggerMock containsMessage:AILogLevelError beginsWith:@"Failed to track session. (response error)"],

AdjustTests/NSURLConnection+NSURLConnectionSynchronousLoadingMocking.m

@@ -29,12 +29,12 @@ + (NSData *)sendSynchronousRequest:(NSURLRequest *)request returningResponse:(NS
     NSString * sResponseBase64;
     if (triggerResponseError) {
         statusCode = 0;
-        //  encoded from "{"error":"response error","tracker_token":"token","tracker_name":"name"}"
-        sResponseBase64 = @"eyJlcnJvciI6InJlc3BvbnNlIGVycm9yIiwidHJhY2tlcl90b2tlbiI6InRva2VuIiwidHJhY2tlcl9uYW1lIjoibmFtZSJ9";
+        //  encoded from "{"error":"response error"}"
+        sResponseBase64 = @"eyJlcnJvciI6InJlc3BvbnNlIGVycm9yIn0=";
     } else {
         statusCode = 200;
-        //  encoded from "{"tracker_token":"token","tracker_name":"name"}"
-        sResponseBase64 = @"eyJ0cmFja2VyX3Rva2VuIjoidG9rZW4iLCJ0cmFja2VyX25hbWUiOiJuYW1lIn0=";
+        //  encoded from "{"tracker_token":"token","tracker_name":"name", "network":"network", "campaign":"campaign", "adgroup":"adgroup", "creative":"creative"}"
+        sResponseBase64 = @"eyJ0cmFja2VyX3Rva2VuIjoidG9rZW4iLCJ0cmFja2VyX25hbWUiOiJuYW1lIiwgIm5ldHdvcmsiOiJuZXR3b3JrIiwgImNhbXBhaWduIjoiY2FtcGFpZ24iLCAiYWRncm91cCI6ImFkZ3JvdXAiLCAiY3JlYXRpdmUiOiJjcmVhdGl2ZSJ9";
     }
     //  build response
     (*response) = [[NSHTTPURLResponse alloc] initWithURL:[[NSURL alloc] init] statusCode:statusCode HTTPVersion:@"" headerFields:nil];