Skip to content

Conversation

@moritzraho
Copy link
Member

@moritzraho moritzraho commented Oct 29, 2025

Description

BREAKING CHANGE
Remove the following global level configuration entries:

  • htmlcacheduration
  • jscacheduration
  • csscacheduration
  • imagecacheduration

Note: we don't deprecated it as we want to favor custom cache-control headers under the correct web configuration category. see adobe/aio-lib-web#227 for more details

This also fixes warning logs that were sent to debugger.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@shazron
Copy link
Member

shazron commented Oct 30, 2025

I'm wondering since this is a breaking change (thus a major) do we want to remove the two other deprecations in this release as well, maybe something we need to discuss.

@moritzraho
Copy link
Member Author

moritzraho commented Oct 30, 2025

I'm wondering since this is a breaking change (thus a major) do we want to remove the two other deprecations in this release as well, maybe something we need to discuss.

Good idea

Edit: after looking into it, some apps may still rely on the old configuration layout. We should (probably) gather some metrics first. Maybe we don't want to add an additional dependency for this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants