feat: improve literal search for member expressions (#7604)

nwidynski · snowystinger · web-flow · commit 4322a3ee2f16 · 2025-02-03T23:40:21.000Z
Co-authored-by: Robert Snow &lt;rsnow@adobe.com&gt;
diff --git a/bin/pure-render.js b/bin/pure-render.js
@@ -52,7 +52,8 @@ module.exports = {
             node.type === 'IfStatement' &&
             node.test.type === 'BinaryExpression' &&
             (node.test.operator === '==' || node.test.operator === '===') &&
-            isMemberExpressionEqual(node.test.left, member)
+            (isMemberExpressionEqual(node.test.left, member) ||
+            isMemberExpressionEqual(node.test.right, member))
           ) {
             conditional = node.test;
           }
@@ -98,7 +99,7 @@ module.exports = {
               type: 'Identifier',
               name: 'undefined'
             };
-            if (isLiteralEqual(conditional.operator, init, conditional.right)) {
+            if (isLiteralEqual(conditional.operator, init, conditional.right) || isLiteralEqual(conditional.operator, init, conditional.left)) {
               return;
             }
           }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,8 @@ module.exports = {`
`52`	`52`	`node.type === 'IfStatement' &&`
`53`	`53`	`node.test.type === 'BinaryExpression' &&`
`54`	`54`	`(node.test.operator === '==' \|\| node.test.operator === '===') &&`
`55`		`- isMemberExpressionEqual(node.test.left, member)`
	`55`	`+ (isMemberExpressionEqual(node.test.left, member) \|\|`
	`56`	`+ isMemberExpressionEqual(node.test.right, member))`
`56`	`57`	`) {`
`57`	`58`	`conditional = node.test;`
`58`	`59`	`}`
`@@ -98,7 +99,7 @@ module.exports = {`
`98`	`99`	`type: 'Identifier',`
`99`	`100`	`name: 'undefined'`
`100`	`101`	`};`
`101`		`- if (isLiteralEqual(conditional.operator, init, conditional.right)) {`
	`102`	`+ if (isLiteralEqual(conditional.operator, init, conditional.right) \|\| isLiteralEqual(conditional.operator, init, conditional.left)) {`
`102`	`103`	`return;`
`103`	`104`	`}`
`104`	`105`	`}`