Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] React 19 peer dependency issue with @react-aria/collections #7583

Open
adriantrunzo opened this issue Jan 8, 2025 · 1 comment
Open
Labels

Comments

@adriantrunzo
Copy link

Provide a general summary of the issue here

While upgrading a project with [email protected] to React 19, I received the following warning from pnpm:

 WARN  Issues with peer dependencies found
.
└─┬ react-aria-components 1.5.0
  └─┬ @react-aria/collections 3.0.0-alpha.6
    └─┬ use-sync-external-store 1.2.2
      └── ✕ unmet peer react@"^16.8.0 || ^17.0.0 || ^18.0.0": found 19.0.0

🤔 Expected Behavior?

No peer dependency warnings with React 19, since react-aria-components accepts v19 in its peer dependency list.

😯 Current Behavior

Peer dependency warning when using React 19 with react-aria-components.

💁 Possible Solution

Updating the use-sync-external-store version to 1.4.0 in

"use-sync-external-store": "^1.2.0"
will resolve the issue. I don't notice any breaking changes in the history for that package: https://github.com/facebook/react/commits/main/packages/use-sync-external-store.

🔦 Context

No response

🖥️ Steps to Reproduce

  1. Create a new project with pnpm, React 19, and React Aria Components 1.5.0
  2. Run pnpm install

Version

react-aria-components 1.5.0

What browsers are you seeing the problem on?

Other

If other, please specify.

Package manager

What operating system are you using?

macOS 15.1.1

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@LFDanLu
Copy link
Member

LFDanLu commented Jan 8, 2025

Thanks for filing this, I've added it to our internal React 19 epic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants