Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't reset form fields if reset event is cancelled. #7603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Don't reset form fields if reset event is cancelled. #7603

wants to merge 1 commit into from
+55 −2

Conversation

nanto
Copy link

@nanto nanto commented Jan 12, 2025

Native form fields don't get reset if a reset event is cancelled. I think it is good that React Aria components behave as the same as native form fields.

Closes #7602

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@nanto nanto closed this Jan 12, 2025
@nanto nanto reopened this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form fields are reset even if reset event is cancelled
1 participant
@nanto