fix: prevent duplicate execution of testenvSettings.sh when DYNAMIC_COMPILE=false (#6765)

* fix: prevent duplicate execution of testenvSettings.sh when DYNAMIC_COMPILE=false

Signed-off-by: Agaba-derrick <[email protected]>

* remove SyntheticGC file and fix the comments

Signed-off-by: Agaba-derrick <[email protected]>

* fix the comments  with the right one

Signed-off-by: Agaba-derrick <[email protected]>

* Update buildenv/jenkins/JenkinsfileBase

Co-authored-by: Martijn Verburg <[email protected]>

---------

Signed-off-by: Agaba-derrick <[email protected]>
Co-authored-by: Shelley Lambert <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>

Author: 3 people

buildenv/jenkins/JenkinsfileBase

@@ -6,7 +6,12 @@ import org.tap4j.model.TestSet;
 def makeTest(testParam) {
 	String tearDownCmd = "$RESOLVED_MAKE; \$MAKE -f ./aqa-tests/TKG/testEnv.mk testEnvTeardown"
 	// Note: keyword source cannot be used in Jenkins script. Therefore, using "." instead.
-	String makeTestCmd = "$RESOLVED_MAKE;cd ./aqa-tests; . ./scripts/testenv/testenvSettings.sh;cd ./TKG; \$MAKE $testParam"
+    // When DYNAMIC_COMPILE=false, do not source testenvSettings.sh (to avoid calling it twice). Only
+    // source the settings when env.DYNAMIC_COMPILE is true.
+	String makeTestCmd = "$RESOLVED_MAKE;cd ./aqa-tests/TKG; \$MAKE $testParam"
+	if (env.DYNAMIC_COMPILE) {
+		makeTestCmd = "$RESOLVED_MAKE;cd ./aqa-tests; . ./scripts/testenv/testenvSettings.sh;cd ./TKG; \$MAKE $testParam"
+	}
 	//unset LD_LIBRARY_PATH workaround for issue https://github.com/adoptium/infrastructure/issues/2934
 	if (JDK_IMPL == 'hotspot' && PLATFORM.contains('alpine-linux')) {
 		makeTestCmd = "unset LD_LIBRARY_PATH; $makeTestCmd"