Skip to content

Commit 69ea4ed

Browse files
committed
Rename XSJS packs to remove async qualifier
We support the non-async versions of XSJS, so rename the packs for clarity.
1 parent 04acfd8 commit 69ea4ed

File tree

6 files changed

+14
-11
lines changed

6 files changed

+14
-11
lines changed

.github/workflows/javascript.sarif.expected

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ jobs:
4141
- name: Perform CodeQL Analysis
4242
id: analyze
4343
uses: github/codeql-action/analyze@v3
44+
env:
45+
LGTM_INDEX_XML_MODE: all
46+
LGTM_INDEX_FILETYPES: ".json:JSON\n.cds:JSON"
4447
```
4548
Example configuration file:
4649
```yaml
@@ -50,7 +53,7 @@ packs:
5053
# Use these packs for JavaScript and TypeScript analysis
5154
javascript:
5255
- codeql/javascript-queries:codeql-suites/javascript-security-extended.qls
53-
- advanced-security/javascript-sap-async-xsjs-queries:codeql-suites/javascript-security-extended.qls
56+
- advanced-security/javascript-sap-xsjs-queries:codeql-suites/javascript-security-extended.qls
5457
- advanced-security/javascript-sap-cap-queries:codeql-suites/javascript-security-extended.qls
5558
- advanced-security/javascript-sap-ui5-queries:codeql-suites/javascript-security-extended.qls
5659

@@ -84,7 +87,7 @@ codeql database create <DB_NAME> --language=javascript
8487
codeql database analyze <DB_NAME> --format=sarif-latest --output=<OUTPUT_FILE> \
8588
--download advanced-security/javascript-sap-cap-queries \
8689
advanced-security/javascript-sap-ui5-queries \
87-
advanced-security/javascript-sap-async-xsjs-queries
90+
advanced-security/javascript-sap-xsjs-queries
8891
```
8992

9093
## License

javascript/frameworks/xsjs/ext/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
library: true
3-
name: advanced-security/javascript-sap-async-xsjs-models
3+
name: advanced-security/javascript-sap-xsjs-models
44
version: 0.1.0
55
extensionTargets:
66
codeql/javascript-all: "^2.0.0"

javascript/frameworks/xsjs/lib/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
library: true
3-
name: advanced-security/javascript-sap-async-xsjs-lib
3+
name: advanced-security/javascript-sap-xsjs-lib
44
version: 0.1.0
55
suites: codeql-suites
66
extractor: javascript
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
22
library: false
3-
name: advanced-security/javascript-sap-async-xsjs-queries
3+
name: advanced-security/javascript-sap-xsjs-queries
44
version: 0.1.0
55
suites: codeql-suites
66
extractor: javascript
77
dependencies:
88
codeql/javascript-all: "^2.0.0"
9-
advanced-security/javascript-sap-async-xsjs-models: "^0.1.0"
10-
advanced-security/javascript-sap-async-xsjs-lib: "^0.1.0"
9+
advanced-security/javascript-sap-xsjs-models: "^0.1.0"
10+
advanced-security/javascript-sap-xsjs-lib: "^0.1.0"
1111
default-suite-file: codeql-suites/javascript-code-scanning.qls
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
---
2-
name: advanced-security/javascript-sap-async-xsjs-tests
2+
name: advanced-security/javascript-sap-xsjs-tests
33
version: 0.1.0
44
extractor: javascript
55
dependencies:
66
codeql/javascript-all: "^2.0.0"
7-
advanced-security/javascript-sap-async-xsjs-queries: "^0.1.0"
8-
advanced-security/javascript-sap-async-xsjs-lib: "^0.1.0"
7+
advanced-security/javascript-sap-xsjs-queries: "^0.1.0"
8+
advanced-security/javascript-sap-xsjs-lib: "^0.1.0"

0 commit comments

Comments
 (0)