Skip to content

Commit c17d100

Browse files
committed
Clean up
1 parent 8838dde commit c17d100

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/build-and-test-wheels-on-one-platform.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'Build and test wheel'
2-
run-name: 'Build wheels (python-versions=${{ inputs.python-versions }}, platform-tag=${{ inputs.platform-tag }}, unoptimized=${{ inputs.unoptimized }}, include-debug-info-for-macos=${{ inputs.include-debug-info-for-macos }}, run_tests_in_this_workflow=${{ inputs.run_tests_in_this_workflow }}, registry-name=${{ inputs.registry-name }}, image-name=${{ inputs.image-name }}, server-tag=${{ inputs.server-tag }}, test-file=${{ inputs.test-file }})'
2+
run-name: 'Build wheels (python-versions=${{ inputs.python-versions }}, platform-tag=${{ inputs.platform-tag }}, unoptimized=${{ inputs.unoptimized }}, include-debug-info-for-macos=${{ inputs.include-debug-info-for-macos }}, run_tests=${{ inputs.run_tests }}, registry-name=${{ inputs.registry-name }}, image-name=${{ inputs.image-name }}, server-tag=${{ inputs.server-tag }}, test-file=${{ inputs.test-file }})'
33

44
# Build wheels on all (or select) Python versions supported by the Python client for a specific platform
55

@@ -23,13 +23,13 @@ on:
2323
# to build wheels for. Actual list inputs aren't supported yet, so it's actually a JSON list encoded as a string.
2424
#
2525
# However, it's harder to combine this workflow (case 1 + 2) with case 3, because matrix outputs don't exist yet
26-
# in Github Actions. So all jobs in the cibuildwheel job would have to pass for a self hosted job to run.
26+
# in Github Actions. So all jobs in the build-wheel job would have to pass for a self hosted job to run.
2727
# We want each platform to be tested independently of each other,
2828
# so there is a wrapper workflow that has a list of platforms to test and reuses this workflow for each platform.
2929
# If one platform fails, it will not affect the building and testing of another platform (we disable fail fast mode)
3030
python-versions:
3131
type: string
32-
description: Valid JSON list of Python tags to build the client for. If *, build for all supported python versions
32+
description: Valid JSON list of Python tags to build the client for.
3333
required: false
3434
default: '["3.10", "3.11", "3.12", "3.13", "3.14"]'
3535
platform-tag:
@@ -54,7 +54,7 @@ on:
5454
type: boolean
5555
required: false
5656
default: false
57-
run_tests_in_this_workflow:
57+
run_tests:
5858
description: 'Run Aerospike server and run tests using built wheels?'
5959
type: boolean
6060
required: false
@@ -132,7 +132,7 @@ jobs:
132132
build-env: "MANYLINUX_REGISTRY_NAME=${{ vars.JF_EXTERNAL_URL }}/${{ vars.JFROG_REPO_FOR_CUSTOM_MANYLINUX_IMAGES }}"
133133

134134
test-wheel:
135-
if: ${{ inputs.run_tests_in_this_workflow && (inputs.platform_tag == 'macosx_arm64' || inputs.platform_tag == 'win_amd64') }}
135+
if: ${{ inputs.run_tests && (inputs.platform_tag == 'macosx_arm64' || inputs.platform_tag == 'win_amd64') }}
136136
needs: [
137137
build-wheel
138138
]
@@ -147,7 +147,7 @@ jobs:
147147
python-version: ${{ matrix.python-version }}
148148

149149
test-manylinux-wheel:
150-
if: ${{ inputs.run_tests_in_this_workflow && startsWith(inputs.platform-tag, 'manylinux') }}
150+
if: ${{ inputs.run_tests && startsWith(inputs.platform-tag, 'manylinux') }}
151151
needs: [
152152
build-wheel
153153
]

0 commit comments

Comments
 (0)