Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose build failed on git-nbdiffdriver #113

Closed
rpranata opened this issue Feb 18, 2020 · 2 comments
Closed

docker-compose build failed on git-nbdiffdriver #113

rpranata opened this issue Feb 18, 2020 · 2 comments

Comments

@rpranata
Copy link

rpranata commented Feb 18, 2020

Reproduction Step

  1. A clean environment
  2. Follow the steps to prepare the handson-ml2 image from the docker setup readme

Expected

The handson-ml2 docker image is created

Actual

Failed when building due to an attempt to import from gitdb.util.compat module.

Step 15/18 : RUN git-nbdiffdriver config --enable --global
 ---> Running in d15cbb46ac68
Traceback (most recent call last):
  File "/opt/conda/envs/tf2/bin/git-nbdiffdriver", line 7, in <module>
    from nbdime.vcs.git.diffdriver import main
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/nbdime/vcs/git/diffdriver.py", line 26, in <module>
    from nbdime.args import (
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/nbdime/args.py", line 18, in <module>
    from .gitfiles import is_gitref
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/nbdime/gitfiles.py", line 11, in <module>
    from git import (
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/git/__init__.py", line 38, in <module>
    from git.exc import *                       # @NoMove @IgnorePep8
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/git/exc.py", line 9, in <module>
    from git.compat import UnicodeMixin, safe_decode, string_types
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/git/compat.py", line 16, in <module>
    from gitdb.utils.compat import (
ModuleNotFoundError: No module named 'gitdb.utils.compat'
ERROR: Service 'handson-ml2' failed to build: The command '/bin/sh -c git-nbdiffdriver config --enable --global' returned a non-zero code: 1

Further investigation led me to believe that the compat module has been removed in gitdb version 3.0.2.

The gitdb is a resolved dependency chain as below

@Harmon758
Copy link

See gitpython-developers/GitPython#983.

@rpranata
Copy link
Author

Thank you @Harmon758.

It works after I explicitly added GitPython dependency with the latest version into the environment.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants