From f815767e15f73a8adfeec157dfb833ca4deeecc8 Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Tue, 31 Dec 2024 13:03:11 -0500 Subject: [PATCH 1/2] update to use LTS Node 18 - Node 14 [fails to install](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139557?pr=112) - ```txt Run actions/setup-node@v3 Attempting to download 14.x... Not found in manifest. Falling back to download directly from Node Error: Unable to find Node version '14.x' for platform darwin and architecture arm64. ``` - keep Node 16 for now, although it is out-of-support - ensure continuous range testing; should bump that later too --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fc983b1..134e59d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,8 +7,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - # TODO: add back Node 18 once node-canvas is properly supported: https://github.com/Automattic/node-canvas/issues/2025 - node-version: [14.x, 16.x] # LTS Node: https://nodejs.org/en/about/releases/ + node-version: [16.x, 18.x] # LTS Node: https://nodejs.org/en/about/releases/ os: [ubuntu-latest, windows-latest, macOS-latest] steps: From 92e3185a81da10ca5e872fb3ae55444c3234046e Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Tue, 31 Dec 2024 13:18:47 -0500 Subject: [PATCH 2/2] try 16.x on Ubuntu only for now - that one [passed](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139677) - 18.x and other 16.x versions failed to install `node-canvas`, c.f. issue comment --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 134e59d..c8fe8da 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,8 +7,9 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - node-version: [16.x, 18.x] # LTS Node: https://nodejs.org/en/about/releases/ - os: [ubuntu-latest, windows-latest, macOS-latest] + # TODO: add back Node 18 once node-canvas is properly supported: https://github.com/Automattic/node-canvas/issues/2025 + node-version: [16.x] # LTS Node: https://nodejs.org/en/about/releases/ + os: [ubuntu-latest] steps: - name: Checkout repo