Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rmccue/requests 2.0.3 #12

Open
StirStudios opened this issue May 31, 2022 · 5 comments
Open

Bump rmccue/requests 2.0.3 #12

StirStudios opened this issue May 31, 2022 · 5 comments

Comments

@StirStudios
Copy link

StirStudios commented May 31, 2022

"require": {
    "rmccue/requests": "^1.7"
},

Any chance we can get a bump so this package is PHP8.1 compatible?

@StirStudios
Copy link
Author

Forked and updated as needed:
https://github.com/StirStudios/Sendy-PHP-API

@zadro
Copy link

zadro commented Aug 31, 2023

Bump to get the rmccue/requests package updated.

@ghost
Copy link

ghost commented Jan 16, 2024

Bump.

   DEPRECATED  Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in vendor/rmccue/requests/library/Requests/Cookie/Jar.php on line 63.

Better would be to remove this dependency and rely on Guzzle instead.

@ghost
Copy link

ghost commented Jan 19, 2024

@StirStudios Your fork throws an error for me. Looks like the composer.json also does not require the Symfony classes btw. Perhaps this would be best: https://symfony.com/doc/current/http_client.html

Call to undefined method Symfony\Component\HttpFoundation\Request::post() in API.php on line 356. Looks like the post method does not exist on the Request class.

[EDIT]
Swapped the HTTP lib for Guzzle: https://github.com/Fossil01/Sendy-PHP-API

@ghost
Copy link

ghost commented Feb 16, 2024

#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants