[FEATURE] detect calls to getResult

[garak]

Description

It would be nice to spot useless calls to getResult, see the example below

Use Case

Bad use:

$users = $repository
    ->createQueryBuilder('u')
    ->leftJoin('u.profile', 'p')
    ->addSelect('p')
    ->getQuery()
    ->getResult();

Good use:

$users = $repository
    ->createQueryBuilder('u')
    ->leftJoin('u.profile', 'p')
    ->addSelect('p')
    ->getQuery()
    ->execute();

Proposed Solution

None

Alternatives Considered

None

[ahmed-bhs]

Thanks @garak ! Quick question before I dig in: what did you have in mind exactly?

From the Doctrine source getResult() is just an alias for execute() (same object hydration, same result), so replacing one with the other does not really change anything.

Were you thinking more about hydration cost — e.g. using getArrayResult() / toIterable() when you only read data? And how would you picture Doctrine Doctor spotting it at runtime?

[garak]

Since getResult() just calls execute(), using' getResult () ' instead of' execute () ' means you're wasting a call.
It's a micro-optimisation, so it's the perfect target for a tool that detects it automatically and saves you the time spent optimising.
About spotting it, I don't have a clue. I didn't dig into your code, and I don't know how it works. I guess it would require a parser.

If you think this is not possible, fair enough. But, at least, don't suggest the wrong way in your documentation.