tests: promote w/ new channel field in notification payload

yasunariw · yasunariw · commit 4f3445711ff8 · 2021-01-04T10:24:38.000+08:00
diff --git a/test/secrets.json b/test/secrets.json
@@ -1,36 +1,3 @@
 {
-    "slack_hooks": [
-        {
-            "url": "https://slack_webhook_url",
-            "channel": "default"
-        },
-        {
-            "url": "https://slack_webhook_url",
-            "channel": "aa"
-        },
-        {
-            "url": "https://slack_webhook_url",
-            "channel": "longest-aa"
-        },
-        {
-            "url": "https://slack_webhook_url",
-            "channel": "backend"
-        },
-        {
-            "url": "https://slack_webhook_url",
-            "channel": "all-push-events"
-        },
-        {
-            "url": "https://slack_webhook_url",
-            "channel": "frontend-bot"
-        },
-        {
-            "url": "https://slack_webhook_url",
-            "channel": "aa-git"
-        },
-        {
-            "url": "https://slack_webhook_url",
-            "channel": "siren"
-        }
-    ]
+    "slack_access_token": ""
 }
diff --git a/test/slack_payloads.expected b/test/slack_payloads.expected
@@ -1,6 +1,7 @@
 ===== file ../mock_payloads/commit_comment.different_author.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "attachments": [
     {
       "fallback":
@@ -18,6 +19,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/commit_comment.general_comment.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "attachments": [
     {
       "fallback":
@@ -33,6 +35,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/commit_comment.general_comment_multiple_path.json =====
 will notify #aa
 {
+  "channel": "aa",
   "attachments": [
     {
       "fallback":
@@ -47,6 +50,7 @@ will notify #aa
 }
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "attachments": [
     {
       "fallback":
@@ -62,6 +66,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/commit_comment.long_comment.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "attachments": [
     {
       "fallback":
@@ -80,6 +85,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/commit_comment.mrkdwn_comment.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "attachments": [
     {
       "fallback":
@@ -98,6 +104,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/commit_comment.multiple_paths.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "attachments": [
     {
       "fallback":
@@ -113,6 +120,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/commit_comment.short_comment.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "attachments": [
     {
       "fallback":
@@ -130,6 +138,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/issue_comment.created_in_issue.json =====
 will notify #default
 {
+  "channel": "default",
   "attachments": [
     {
       "fallback":
@@ -145,6 +154,7 @@ will notify #default
 ===== file ../mock_payloads/issue_comment.created_in_pr.json =====
 will notify #aa-git
 {
+  "channel": "aa-git",
   "attachments": [
     {
       "fallback":
@@ -159,6 +169,7 @@ will notify #aa-git
 }
 will notify #backend
 {
+  "channel": "backend",
   "attachments": [
     {
       "fallback":
@@ -175,6 +186,7 @@ will notify #backend
 ===== file ../mock_payloads/issue_comment.draft_pr.json =====
 will notify #frontend-bot
 {
+  "channel": "frontend-bot",
   "attachments": [
     {
       "fallback":
@@ -192,6 +204,7 @@ will notify #frontend-bot
 ===== file ../mock_payloads/issues.closed.json =====
 will notify #backend
 {
+  "channel": "backend",
   "attachments": [
     {
       "fallback":
@@ -206,6 +219,7 @@ will notify #backend
 ===== file ../mock_payloads/issues.labeled.json =====
 will notify #backend
 {
+  "channel": "backend",
   "attachments": [
     {
       "fallback":
@@ -221,6 +235,7 @@ will notify #backend
 ===== file ../mock_payloads/issues.opened.json =====
 will notify #default
 {
+  "channel": "default",
   "attachments": [
     {
       "fallback":
@@ -237,6 +252,7 @@ will notify #default
 ===== file ../mock_payloads/issues.reopened.json =====
 will notify #backend
 {
+  "channel": "backend",
   "attachments": [
     {
       "fallback":
@@ -251,6 +267,7 @@ will notify #backend
 ===== file ../mock_payloads/pull_request.closed_capitalized.json =====
 will notify #aa-git
 {
+  "channel": "aa-git",
   "attachments": [
     {
       "fallback":
@@ -265,6 +282,7 @@ will notify #aa-git
 ===== file ../mock_payloads/pull_request.closed_no_labels.json =====
 will notify #default
 {
+  "channel": "default",
   "attachments": [
     {
       "fallback":
@@ -279,6 +297,7 @@ will notify #default
 ===== file ../mock_payloads/pull_request.labeled_two_labels.json =====
 will notify #aa-git
 {
+  "channel": "aa-git",
   "attachments": [
     {
       "fallback":
@@ -293,6 +312,7 @@ will notify #aa-git
 }
 will notify #backend
 {
+  "channel": "backend",
   "attachments": [
     {
       "fallback":
@@ -308,6 +328,7 @@ will notify #backend
 ===== file ../mock_payloads/pull_request.opened_one_label.json =====
 will notify #frontend-bot
 {
+  "channel": "frontend-bot",
   "attachments": [
     {
       "fallback":
@@ -324,6 +345,7 @@ will notify #frontend-bot
 ===== file ../mock_payloads/pull_request_review.approved.json =====
 will notify #default
 {
+  "channel": "default",
   "attachments": [
     {
       "fallback":
@@ -339,6 +361,7 @@ will notify #default
 ===== file ../mock_payloads/pull_request_review.commented.json =====
 will notify #frontend-bot
 {
+  "channel": "frontend-bot",
   "attachments": [
     {
       "fallback":
@@ -356,6 +379,7 @@ will notify #frontend-bot
 ===== file ../mock_payloads/pull_request_review.request_changes.json =====
 will notify #default
 {
+  "channel": "default",
   "attachments": [
     {
       "fallback":
@@ -373,6 +397,7 @@ will notify #default
 ===== file ../mock_payloads/pull_request_review_comment.created.json =====
 will notify #aa-git
 {
+  "channel": "aa-git",
   "attachments": [
     {
       "fallback":
@@ -389,6 +414,7 @@ will notify #aa-git
 }
 will notify #backend
 {
+  "channel": "backend",
   "attachments": [
     {
       "fallback":
@@ -408,6 +434,7 @@ will notify #backend
 ===== file ../mock_payloads/push.two_commits.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "text":
     "<https://github.com/thatportugueseguy/webhooks-test/tree/master|[webhooks-test:master]> <https://github.com/thatportugueseguy/webhooks-test/compare/fb245e2a6d52...e2173f38ae43|2 commits> pushed by thatportugueseguy",
   "attachments": [
@@ -427,6 +454,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/push.two_commits_longest_match.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "text":
     "<https://github.com/thatportugueseguy/webhooks-test/tree/master|[webhooks-test:master]> <https://github.com/thatportugueseguy/webhooks-test/compare/fb245e2a6d52...e2173f38ae43|2 commits> pushed by thatportugueseguy",
   "attachments": [
@@ -445,6 +473,7 @@ will notify #all-push-events
 }
 will notify #longest-aa
 {
+  "channel": "longest-aa",
   "text":
     "<https://github.com/thatportugueseguy/webhooks-test/tree/master|[webhooks-test:master]> <https://github.com/thatportugueseguy/webhooks-test/compare/fb245e2a6d52...e2173f38ae43|1 commit> pushed by thatportugueseguy",
   "attachments": [
@@ -465,6 +494,7 @@ will notify #longest-aa
 ===== file ../mock_payloads/status.failure_test.json =====
 will notify #default
 {
+  "channel": "default",
   "attachments": [
     {
       "fallback":
@@ -490,6 +520,7 @@ will notify #default
 ===== file ../mock_payloads/status.success_public_repo_no_buildkite.json =====
 will notify #default
 {
+  "channel": "default",
   "attachments": [
     {
       "fallback":
@@ -510,6 +541,7 @@ will notify #default
 ===== file ../mock_payloads/status.success_test_main_branch.json =====
 will notify #all-push-events
 {
+  "channel": "all-push-events",
   "attachments": [
     {
       "fallback":
@@ -531,6 +563,7 @@ will notify #all-push-events
 ===== file ../mock_payloads/status.success_test_non_main_branch.json =====
 will notify #default
 {
+  "channel": "default",
   "attachments": [
     {
       "fallback":

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`===== file ../mock_payloads/commit_comment.different_author.json =====`
`2`	`2`	`will notify #all-push-events`
`3`	`3`	`{`
	`4`	`+ "channel": "all-push-events",`
`4`	`5`	`"attachments": [`
`5`	`6`	`{`
`6`	`7`	`"fallback":`
`@@ -18,6 +19,7 @@ will notify #all-push-events`
`18`	`19`	`===== file ../mock_payloads/commit_comment.general_comment.json =====`
`19`	`20`	`will notify #all-push-events`
`20`	`21`	`{`
	`22`	`+ "channel": "all-push-events",`
`21`	`23`	`"attachments": [`
`22`	`24`	`{`
`23`	`25`	`"fallback":`
`@@ -33,6 +35,7 @@ will notify #all-push-events`
`33`	`35`	`===== file ../mock_payloads/commit_comment.general_comment_multiple_path.json =====`
`34`	`36`	`will notify #aa`
`35`	`37`	`{`
	`38`	`+ "channel": "aa",`
`36`	`39`	`"attachments": [`
`37`	`40`	`{`
`38`	`41`	`"fallback":`
`@@ -47,6 +50,7 @@ will notify #aa`
`47`	`50`	`}`
`48`	`51`	`will notify #all-push-events`
`49`	`52`	`{`
	`53`	`+ "channel": "all-push-events",`
`50`	`54`	`"attachments": [`
`51`	`55`	`{`
`52`	`56`	`"fallback":`
`@@ -62,6 +66,7 @@ will notify #all-push-events`
`62`	`66`	`===== file ../mock_payloads/commit_comment.long_comment.json =====`
`63`	`67`	`will notify #all-push-events`
`64`	`68`	`{`
	`69`	`+ "channel": "all-push-events",`
`65`	`70`	`"attachments": [`
`66`	`71`	`{`
`67`	`72`	`"fallback":`
`@@ -80,6 +85,7 @@ will notify #all-push-events`
`80`	`85`	`===== file ../mock_payloads/commit_comment.mrkdwn_comment.json =====`
`81`	`86`	`will notify #all-push-events`
`82`	`87`	`{`
	`88`	`+ "channel": "all-push-events",`
`83`	`89`	`"attachments": [`
`84`	`90`	`{`
`85`	`91`	`"fallback":`
`@@ -98,6 +104,7 @@ will notify #all-push-events`
`98`	`104`	`===== file ../mock_payloads/commit_comment.multiple_paths.json =====`
`99`	`105`	`will notify #all-push-events`
`100`	`106`	`{`
	`107`	`+ "channel": "all-push-events",`
`101`	`108`	`"attachments": [`
`102`	`109`	`{`
`103`	`110`	`"fallback":`
`@@ -113,6 +120,7 @@ will notify #all-push-events`
`113`	`120`	`===== file ../mock_payloads/commit_comment.short_comment.json =====`
`114`	`121`	`will notify #all-push-events`
`115`	`122`	`{`
	`123`	`+ "channel": "all-push-events",`
`116`	`124`	`"attachments": [`
`117`	`125`	`{`
`118`	`126`	`"fallback":`
`@@ -130,6 +138,7 @@ will notify #all-push-events`
`130`	`138`	`===== file ../mock_payloads/issue_comment.created_in_issue.json =====`
`131`	`139`	`will notify #default`
`132`	`140`	`{`
	`141`	`+ "channel": "default",`
`133`	`142`	`"attachments": [`
`134`	`143`	`{`
`135`	`144`	`"fallback":`
`@@ -145,6 +154,7 @@ will notify #default`
`145`	`154`	`===== file ../mock_payloads/issue_comment.created_in_pr.json =====`
`146`	`155`	`will notify #aa-git`
`147`	`156`	`{`
	`157`	`+ "channel": "aa-git",`
`148`	`158`	`"attachments": [`
`149`	`159`	`{`
`150`	`160`	`"fallback":`
`@@ -159,6 +169,7 @@ will notify #aa-git`
`159`	`169`	`}`
`160`	`170`	`will notify #backend`
`161`	`171`	`{`
	`172`	`+ "channel": "backend",`
`162`	`173`	`"attachments": [`
`163`	`174`	`{`
`164`	`175`	`"fallback":`
`@@ -175,6 +186,7 @@ will notify #backend`
`175`	`186`	`===== file ../mock_payloads/issue_comment.draft_pr.json =====`
`176`	`187`	`will notify #frontend-bot`
`177`	`188`	`{`
	`189`	`+ "channel": "frontend-bot",`
`178`	`190`	`"attachments": [`
`179`	`191`	`{`
`180`	`192`	`"fallback":`
`@@ -192,6 +204,7 @@ will notify #frontend-bot`
`192`	`204`	`===== file ../mock_payloads/issues.closed.json =====`
`193`	`205`	`will notify #backend`
`194`	`206`	`{`
	`207`	`+ "channel": "backend",`
`195`	`208`	`"attachments": [`
`196`	`209`	`{`
`197`	`210`	`"fallback":`
`@@ -206,6 +219,7 @@ will notify #backend`
`206`	`219`	`===== file ../mock_payloads/issues.labeled.json =====`
`207`	`220`	`will notify #backend`
`208`	`221`	`{`
	`222`	`+ "channel": "backend",`
`209`	`223`	`"attachments": [`
`210`	`224`	`{`
`211`	`225`	`"fallback":`
`@@ -221,6 +235,7 @@ will notify #backend`
`221`	`235`	`===== file ../mock_payloads/issues.opened.json =====`
`222`	`236`	`will notify #default`
`223`	`237`	`{`
	`238`	`+ "channel": "default",`
`224`	`239`	`"attachments": [`
`225`	`240`	`{`
`226`	`241`	`"fallback":`
`@@ -237,6 +252,7 @@ will notify #default`
`237`	`252`	`===== file ../mock_payloads/issues.reopened.json =====`
`238`	`253`	`will notify #backend`
`239`	`254`	`{`
	`255`	`+ "channel": "backend",`
`240`	`256`	`"attachments": [`
`241`	`257`	`{`
`242`	`258`	`"fallback":`
`@@ -251,6 +267,7 @@ will notify #backend`
`251`	`267`	`===== file ../mock_payloads/pull_request.closed_capitalized.json =====`
`252`	`268`	`will notify #aa-git`
`253`	`269`	`{`
	`270`	`+ "channel": "aa-git",`
`254`	`271`	`"attachments": [`
`255`	`272`	`{`
`256`	`273`	`"fallback":`
`@@ -265,6 +282,7 @@ will notify #aa-git`
`265`	`282`	`===== file ../mock_payloads/pull_request.closed_no_labels.json =====`
`266`	`283`	`will notify #default`
`267`	`284`	`{`
	`285`	`+ "channel": "default",`
`268`	`286`	`"attachments": [`
`269`	`287`	`{`
`270`	`288`	`"fallback":`
`@@ -279,6 +297,7 @@ will notify #default`
`279`	`297`	`===== file ../mock_payloads/pull_request.labeled_two_labels.json =====`
`280`	`298`	`will notify #aa-git`
`281`	`299`	`{`
	`300`	`+ "channel": "aa-git",`
`282`	`301`	`"attachments": [`
`283`	`302`	`{`
`284`	`303`	`"fallback":`
`@@ -293,6 +312,7 @@ will notify #aa-git`
`293`	`312`	`}`
`294`	`313`	`will notify #backend`
`295`	`314`	`{`
	`315`	`+ "channel": "backend",`
`296`	`316`	`"attachments": [`
`297`	`317`	`{`
`298`	`318`	`"fallback":`
`@@ -308,6 +328,7 @@ will notify #backend`
`308`	`328`	`===== file ../mock_payloads/pull_request.opened_one_label.json =====`
`309`	`329`	`will notify #frontend-bot`
`310`	`330`	`{`
	`331`	`+ "channel": "frontend-bot",`
`311`	`332`	`"attachments": [`
`312`	`333`	`{`
`313`	`334`	`"fallback":`
`@@ -324,6 +345,7 @@ will notify #frontend-bot`
`324`	`345`	`===== file ../mock_payloads/pull_request_review.approved.json =====`
`325`	`346`	`will notify #default`
`326`	`347`	`{`
	`348`	`+ "channel": "default",`
`327`	`349`	`"attachments": [`
`328`	`350`	`{`
`329`	`351`	`"fallback":`
`@@ -339,6 +361,7 @@ will notify #default`
`339`	`361`	`===== file ../mock_payloads/pull_request_review.commented.json =====`
`340`	`362`	`will notify #frontend-bot`
`341`	`363`	`{`
	`364`	`+ "channel": "frontend-bot",`
`342`	`365`	`"attachments": [`
`343`	`366`	`{`
`344`	`367`	`"fallback":`
`@@ -356,6 +379,7 @@ will notify #frontend-bot`
`356`	`379`	`===== file ../mock_payloads/pull_request_review.request_changes.json =====`
`357`	`380`	`will notify #default`
`358`	`381`	`{`
	`382`	`+ "channel": "default",`
`359`	`383`	`"attachments": [`
`360`	`384`	`{`
`361`	`385`	`"fallback":`
`@@ -373,6 +397,7 @@ will notify #default`
`373`	`397`	`===== file ../mock_payloads/pull_request_review_comment.created.json =====`
`374`	`398`	`will notify #aa-git`
`375`	`399`	`{`
	`400`	`+ "channel": "aa-git",`
`376`	`401`	`"attachments": [`
`377`	`402`	`{`
`378`	`403`	`"fallback":`
`@@ -389,6 +414,7 @@ will notify #aa-git`
`389`	`414`	`}`
`390`	`415`	`will notify #backend`
`391`	`416`	`{`
	`417`	`+ "channel": "backend",`
`392`	`418`	`"attachments": [`
`393`	`419`	`{`
`394`	`420`	`"fallback":`
`@@ -408,6 +434,7 @@ will notify #backend`
`408`	`434`	`===== file ../mock_payloads/push.two_commits.json =====`
`409`	`435`	`will notify #all-push-events`
`410`	`436`	`{`
	`437`	`+ "channel": "all-push-events",`
`411`	`438`	`"text":`
`412`	`439`	`"<https://github.com/thatportugueseguy/webhooks-test/tree/master\|[webhooks-test:master]> <https://github.com/thatportugueseguy/webhooks-test/compare/fb245e2a6d52...e2173f38ae43\|2 commits> pushed by thatportugueseguy",`
`413`	`440`	`"attachments": [`
`@@ -427,6 +454,7 @@ will notify #all-push-events`
`427`	`454`	`===== file ../mock_payloads/push.two_commits_longest_match.json =====`
`428`	`455`	`will notify #all-push-events`
`429`	`456`	`{`
	`457`	`+ "channel": "all-push-events",`
`430`	`458`	`"text":`
`431`	`459`	`"<https://github.com/thatportugueseguy/webhooks-test/tree/master\|[webhooks-test:master]> <https://github.com/thatportugueseguy/webhooks-test/compare/fb245e2a6d52...e2173f38ae43\|2 commits> pushed by thatportugueseguy",`
`432`	`460`	`"attachments": [`
`@@ -445,6 +473,7 @@ will notify #all-push-events`
`445`	`473`	`}`
`446`	`474`	`will notify #longest-aa`
`447`	`475`	`{`
	`476`	`+ "channel": "longest-aa",`
`448`	`477`	`"text":`
`449`	`478`	`"<https://github.com/thatportugueseguy/webhooks-test/tree/master\|[webhooks-test:master]> <https://github.com/thatportugueseguy/webhooks-test/compare/fb245e2a6d52...e2173f38ae43\|1 commit> pushed by thatportugueseguy",`
`450`	`479`	`"attachments": [`
`@@ -465,6 +494,7 @@ will notify #longest-aa`
`465`	`494`	`===== file ../mock_payloads/status.failure_test.json =====`
`466`	`495`	`will notify #default`
`467`	`496`	`{`
	`497`	`+ "channel": "default",`
`468`	`498`	`"attachments": [`
`469`	`499`	`{`
`470`	`500`	`"fallback":`
`@@ -490,6 +520,7 @@ will notify #default`
`490`	`520`	`===== file ../mock_payloads/status.success_public_repo_no_buildkite.json =====`
`491`	`521`	`will notify #default`
`492`	`522`	`{`
	`523`	`+ "channel": "default",`
`493`	`524`	`"attachments": [`
`494`	`525`	`{`
`495`	`526`	`"fallback":`
`@@ -510,6 +541,7 @@ will notify #default`
`510`	`541`	`===== file ../mock_payloads/status.success_test_main_branch.json =====`
`511`	`542`	`will notify #all-push-events`
`512`	`543`	`{`
	`544`	`+ "channel": "all-push-events",`
`513`	`545`	`"attachments": [`
`514`	`546`	`{`
`515`	`547`	`"fallback":`
`@@ -531,6 +563,7 @@ will notify #all-push-events`
`531`	`563`	`===== file ../mock_payloads/status.success_test_non_main_branch.json =====`
`532`	`564`	`will notify #default`
`533`	`565`	`{`
	`566`	`+ "channel": "default",`
`534`	`567`	`"attachments": [`
`535`	`568`	`{`
`536`	`569`	`"fallback":`