Skip to content

Commit 0f63a05

Browse files
authored
fix: etcd bucket delete missing prefix and metrics test range (#3331)
Signed-off-by: Keiven Chang <[email protected]>
1 parent 2a2bf58 commit 0f63a05

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lib/runtime/src/metrics.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1593,8 +1593,8 @@ mod test_metricsregistry_nats {
15931593
(
15941594
build_component_metric_name(nats_service::REQUESTS_TOTAL),
15951595
0.0,
1596-
0.0,
1597-
), // No work handler requests
1596+
10.0,
1597+
), // NATS service stats requests (may differ from work handler count)
15981598
(
15991599
build_component_metric_name(nats_service::PROCESSING_MS_TOTAL),
16001600
0.0,

lib/runtime/src/storage/key_value_store/etcd.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ impl KeyValueBucket for EtcdBucket {
7070
}
7171

7272
async fn get(&self, key: &Key) -> Result<Option<bytes::Bytes>, StorageError> {
73-
let k = format!("{}/{key}", self.bucket_name);
73+
let k = make_key(&self.bucket_name, key);
7474
tracing::trace!("etcd get: {k}");
7575

7676
let mut kvs = self
@@ -86,9 +86,11 @@ impl KeyValueBucket for EtcdBucket {
8686
}
8787

8888
async fn delete(&self, key: &Key) -> Result<(), StorageError> {
89+
let k = make_key(&self.bucket_name, key);
90+
tracing::trace!("etcd delete: {k}");
8991
let _ = self
9092
.client
91-
.kv_delete(key.0.clone(), None)
93+
.kv_delete(k, None)
9294
.await
9395
.map_err(|e| StorageError::EtcdError(e.to_string()))?;
9496
Ok(())

0 commit comments

Comments
 (0)