Skip to content

Commit 37cf5a2

Browse files
committed
updates from other PR
1 parent 507a89e commit 37cf5a2

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.github/workflows/build-and-test-vllm.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@
1515

1616
name: NVIDIA Github Validation - vLLM
1717

18+
# Do not cancel merges into main
19+
concurrency:
20+
group: pr-build-test-vllm-${{ github.event.number || github.run_id }}
21+
cancel-in-progress: ${{ github.ref_name != 'main' }}
22+
1823
on:
1924
push:
2025
branches:
@@ -23,8 +28,7 @@ on:
2328

2429
jobs:
2530
build-test:
26-
runs-on:
27-
group: GPU_runners
31+
runs-on: gpu-l40-runners
2832
name: Build and Test - vLLM
2933
env:
3034
CONTAINER_ID: test_${{ github.run_id }}_${{ github.run_attempt }}_${{ github.job }}_vllm
@@ -51,9 +55,9 @@ jobs:
5155
./container/build.sh --tag ${{ steps.define_image_tag.outputs.image_tag }} --target runtime --framework vllm
5256
- name: Run pytest
5357
env:
54-
PYTEST_MARKS: "e2e and vllm and gpu_1 and serve"
58+
PYTEST_MARKS: "e2e and vllm and gpu_1 and not slow"
5559
run: |
56-
docker run --gpus all-v ${{ github.workspace }}:/workspace -w /workspace --name ${{ env.CONTAINER_ID }}_pytest ${{ steps.define_image_tag.outputs.image_tag }} bash -c "pytest --basetemp=/tmp --junitxml=${{ env.PYTEST_XML_FILE }} -m \"${{ env.PYTEST_MARKS }}\""
60+
docker run --gpus all -v ${{ github.workspace }}:/workspace -w /workspace --name ${{ env.CONTAINER_ID }}_pytest ${{ steps.define_image_tag.outputs.image_tag }} bash -c "pytest --basetemp=/tmp --junitxml=${{ env.PYTEST_XML_FILE }} -m \"${{ env.PYTEST_MARKS }}\""
5761
- name: Cleanup - Remove dynamo directory
5862
if: always()
5963
run: |

tests/serve/test_vllm.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,8 +302,6 @@ def vllm_config_test(request):
302302

303303

304304
@pytest.mark.e2e
305-
@pytest.mark.slow
306-
@pytest.mark.serve
307305
def test_serve_deployment(vllm_config_test, request, runtime_services):
308306
"""
309307
Test dynamo serve deployments with different graph configurations.

0 commit comments

Comments
 (0)