Skip to content

Commit e63ec2e

Browse files
dillon-cullinantedzhouhk
authored andcommitted
ci: OPS-724: Move to ARC runners (#2904)
Signed-off-by: Dillon Cullinan <[email protected]> Signed-off-by: hongkuanz <[email protected]>
1 parent ebc7611 commit e63ec2e

File tree

4 files changed

+21
-7
lines changed

4 files changed

+21
-7
lines changed

.github/workflows/container-validation-backends.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111

1212
jobs:
1313
build-test:
14-
runs-on: gpu-l40-runners
14+
runs-on: gpu-l40-amd64
1515
strategy:
1616
matrix:
1717
framework: [vllm]
@@ -45,16 +45,13 @@ jobs:
4545
if: always()
4646
run: |
4747
docker system prune -af
48-
- name: Debug
49-
run: |
50-
lsmod | grep nvidia
51-
sudo dmesg | grep -i nvrm || true
52-
nvidia-smi
5348
- name: Build image
5449
env:
5550
GITHUB_TOKEN: ${{ secrets.CI_TOKEN }}
5651
AWS_DEFAULT_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
5752
SCCACHE_S3_BUCKET: ${{ secrets.SCCACHE_S3_BUCKET }}
53+
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
54+
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
5855
run: |
5956
./container/build.sh --tag ${{ matrix.framework }}:latest \
6057
--target ${{ matrix.target }} \
@@ -64,7 +61,8 @@ jobs:
6461
--sccache-region "$AWS_DEFAULT_REGION"
6562
- name: Run pytest
6663
run: |
67-
docker run --rm --gpus all -w /workspace \
64+
docker run --runtime=nvidia --rm --gpus all -w /workspace \
65+
--network host \
6866
--name ${{ env.CONTAINER_ID }}_pytest \
6967
${{ matrix.framework }}:latest \
7068
bash -c "pytest -xsv --basetemp=/tmp --junitxml=${{ env.PYTEST_XML_FILE }} -m \"${{ env.PYTEST_MARKS }}\""

container/Dockerfile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ ARG ARCH_ALT=x86_64
3535
ARG USE_SCCACHE
3636
ARG SCCACHE_BUCKET=""
3737
ARG SCCACHE_REGION=""
38+
ARG AWS_ACCESS_KEY_ID=""
39+
ARG AWS_SECRET_ACCESS_KEY=""
3840

3941
# NIXL configuration
4042
ARG NIXL_UCX_REF=v1.19.0
@@ -56,6 +58,8 @@ ARG PYTHON_VERSION
5658
ARG USE_SCCACHE
5759
ARG SCCACHE_BUCKET
5860
ARG SCCACHE_REGION
61+
ARG AWS_ACCESS_KEY_ID
62+
ARG AWS_SECRET_ACCESS_KEY
5963
ARG NIXL_UCX_REF
6064
ARG NIXL_REF
6165

@@ -268,6 +272,8 @@ ARG ENABLE_KVBM
268272
ARG USE_SCCACHE
269273
ARG SCCACHE_BUCKET
270274
ARG SCCACHE_REGION
275+
ARG AWS_ACCESS_KEY_ID
276+
ARG AWS_SECRET_ACCESS_KEY
271277

272278
WORKDIR /opt/dynamo
273279

container/Dockerfile.vllm

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ ARG TORCH_BACKEND="cu128"
2020
ARG USE_SCCACHE
2121
ARG SCCACHE_BUCKET=""
2222
ARG SCCACHE_REGION=""
23+
ARG AWS_ACCESS_KEY_ID=""
24+
ARG AWS_SECRET_ACCESS_KEY=""
2325

2426
# Match 0.10.1.1 vLLM release
2527
# https://github.com/vllm-project/vllm/releases/tag/v0.10.1.1
@@ -119,6 +121,8 @@ ARG USE_SCCACHE
119121
ARG ARCH_ALT
120122
ARG SCCACHE_BUCKET
121123
ARG SCCACHE_REGION
124+
ARG AWS_ACCESS_KEY_ID=""
125+
ARG AWS_SECRET_ACCESS_KEY=""
122126

123127
ENV ARCH_ALT=${ARCH_ALT}
124128
RUN if [ "$USE_SCCACHE" = "true" ]; then \

container/build.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,10 @@ show_help() {
429429
echo " [--use-sccache enable sccache for Rust/C/C++ compilation caching]"
430430
echo " [--sccache-bucket S3 bucket name for sccache (required with --use-sccache)]"
431431
echo " [--sccache-region S3 region for sccache (required with --use-sccache)]"
432+
echo ""
433+
echo " Note: When using --use-sccache, AWS credentials must be set:"
434+
echo " export AWS_ACCESS_KEY_ID=your_access_key"
435+
echo " export AWS_SECRET_ACCESS_KEY=your_secret_key"
432436
exit 0
433437
}
434438

@@ -598,6 +602,8 @@ if [ "$USE_SCCACHE" = true ]; then
598602
BUILD_ARGS+=" --build-arg USE_SCCACHE=true"
599603
BUILD_ARGS+=" --build-arg SCCACHE_BUCKET=${SCCACHE_BUCKET}"
600604
BUILD_ARGS+=" --build-arg SCCACHE_REGION=${SCCACHE_REGION}"
605+
BUILD_ARGS+=" --build-arg AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}"
606+
BUILD_ARGS+=" --build-arg AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}"
601607
fi
602608

603609
LATEST_TAG="--tag dynamo:latest-${FRAMEWORK,,}"

0 commit comments

Comments
 (0)