Skip to content

Conversation

@bgola
Copy link
Contributor

@bgola bgola commented Nov 27, 2025

WIP :)

@adcxyz
Copy link
Member

adcxyz commented Nov 28, 2025

looks great, thanks!
will test and report ASAP!

@adcxyz
Copy link
Member

adcxyz commented Nov 28, 2025

Everything looks good, just one detail popped up with this PR:

In NTMI Ndefs, \amp is intended to be the momentary amp control for articulation by NTMI, influx etc.
line 76 in NTMI.slots.playAt was:
obj.set(\amp, NTMI.slots.defaultAmp);
This means a sound in that slot always begins with medium \amp, so one can articulate up and down from there.
this is good for sounds that have not played before, which have \amp at 0 by convention,
but maybe not ideal for sounds that have already played, as it changes their \amp setting.
When you stop playing a sound, its \amp setting will be anywhere between 0 and 1,
depending on current articulation, so maybe this setting is not sacred to keep.
Only when you use an Ndef elsewhere as a source, and \amp is reset, its level will will jump there,
but since you began playing it in NTMI, its amp will change now in any case.

Options:
A - keep current behavior by keeping line 76 -> whenever you play a sound in NTMI, its \amp may jump.
B - on startup, make the default \amp setting NTMI.slots.defaultAmp and don't touch \amp afterwards
C - when running playAt, only if \amp is 0, set to NTMI.slots.defaultAmp, else don't touch.
D - this PR drops line 76, so as is, sounds always begin at \amp 0, which is confusing IMO.

What do you think?

@bgola
Copy link
Contributor Author

bgola commented Nov 28, 2025

I think I dropped that line some time ago because some of my sounds don't have amp = 0 by default necessarily. And when playing I prefer that NTMI keeps the amp settings as before.

So maybe setting it once at startup as you suggested is a good approach?

1 similar comment
@bgola
Copy link
Contributor Author

bgola commented Nov 28, 2025

I think I dropped that line some time ago because some of my sounds don't have amp = 0 by default necessarily. And when playing I prefer that NTMI keeps the amp settings as before.

So maybe setting it once at startup as you suggested is a good approach?

@adcxyz
Copy link
Member

adcxyz commented Nov 28, 2025

or making it a flag, such as
NTMI.setAmpInPlayAt = true;
I will try playing without resetting for a few days, to see if I would like the reset to middle well enough to keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants