fix(click-handler): fix shift selection not working on folder with note

also remove shift key option for new note modifier in the setting tab

Author: aidenlx

src/click-handler.ts

@@ -9,13 +9,17 @@ export const getClickHandler = (plugin: ALxFolderNote) => {
   return async (item: FolderItem, evt: MouseEvent): Promise<boolean> => {
     if (
       !item ||
+      (Platform.isMobile && !plugin.settings.mobileClickToOpen) ||
+      // allow folder shift selection to work
+      evt.shiftKey ||
+      // allow collapse indicator to work
       item.collapseIndicatorEl === evt.target ||
       item.collapseIndicatorEl.contains(evt.target as Node) ||
-      item.fileExplorer.fileBeingRenamed === item.file ||
-      (Platform.isMobile && !plugin.settings.mobileClickToOpen)
+      // ignore file being renamed
+      item.fileExplorer.fileBeingRenamed === item.file
     )
       return false;
-    // check if dblclick is triggered
+
     if (evt.type === "auxclick" && evt.button !== 1) return false;
 
     // get the folder path

src/settings.ts

@@ -182,28 +182,29 @@ export class ALxFolderNoteSettingTab extends PluginSettingTab {
       .setName("Modifier for New Note")
       .setDesc("Choose a modifier to click folders with to create folder notes")
       .addDropdown((dropDown) => {
-        const windowsOpts: Record<Modifier, string> = {
+        type NoShift = Exclude<Modifier, "Shift">;
+        const windowsOpts: Record<NoShift, string> = {
           Mod: "Ctrl (Cmd in macOS)",
           Ctrl: "Ctrl (Ctrl in macOS)",
           Meta: "⊞ Win",
-          Shift: "Shift",
+          // Shift: "Shift",
           Alt: "Alt",
         };
-        const macOSOpts: Record<Modifier, string> = {
-          Mod: "⌘ Cmd (Ctrl)",
+        const macOSOpts: Record<NoShift, string> = {
+          Mod: "⌘ Cmd (Ctrl in Windows)",
           Ctrl: "⌃ Control",
-          Meta: "⌘ Cmd (Win)",
-          Shift: "⇧ Shift",
+          Meta: "⌘ Cmd (Win in Windows)",
+          // Shift: "⇧ Shift",
           Alt: "⌥ Option",
         };
 
         const options = Platform.isMacOS ? macOSOpts : windowsOpts;
 
         dropDown
           .addOptions(options)
-          .setValue(this.plugin.settings.modifierForNewNote.toString())
+          .setValue(this.plugin.settings.modifierForNewNote)
           .onChange(async (value: string) => {
-            this.plugin.settings.modifierForNewNote = value as Modifier;
+            this.plugin.settings.modifierForNewNote = value as NoShift;
             await this.plugin.saveSettings();
           });
       });