Skip to content

Commit d78bc98

Browse files
committed
Resolve linting errors after upgrades
1 parent 84b1f2e commit d78bc98

File tree

7 files changed

+7
-5
lines changed

7 files changed

+7
-5
lines changed

.eslintrc.js

+2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ module.exports = {
2222
"files": ["src/**/*.{ts,tsx}"],
2323
"extends": ["matrix-org/ts"],
2424
"rules": {
25+
// We're okay being explicit at the moment
26+
"@typescript-eslint/no-empty-interface": "off",
2527
// We disable this while we're transitioning
2628
"@typescript-eslint/no-explicit-any": "off",
2729
// We'd rather not do this but we do

res/css/structures/_RoomView.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ hr.mx_RoomView_myReadMarker {
219219
position: relative;
220220
top: -1px;
221221
z-index: 1;
222-
transition: width 400ms easeInSine 1s, opacity 400ms easeInSine 1s;
222+
transition: width 400ms easeinsine 1s, opacity 400ms easeinsine 1s;
223223
width: 99%;
224224
opacity: 1;
225225
}

src/IdentityAuthClient.js

+1
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ export default class IdentityAuthClient {
165165
});
166166
const [confirmed] = await finished;
167167
if (confirmed) {
168+
// eslint-disable-next-line react-hooks/rules-of-hooks
168169
useDefaultIdentityServer();
169170
} else {
170171
throw new AbortedIdentityActionError(

src/components/structures/LeftPanelWidget.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ const LeftPanelWidget: React.FC<IProps> = ({ onResize }) => {
5656

5757
const [height, setHeight] = useLocalStorageState("left-panel-widget-height", INITIAL_HEIGHT);
5858
const [expanded, setExpanded] = useLocalStorageState("left-panel-widget-expanded", true);
59-
useEffect(onResize, [expanded]);
59+
useEffect(onResize, [expanded, onResize]);
6060

6161
const [onFocus, isActive, ref] = useRovingTabIndex();
6262
const tabIndex = isActive ? 0 : -1;

src/components/structures/TabbedView.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import * as React from "react";
2020
import {_t} from '../../languageHandler';
2121
import * as sdk from "../../index";
2222
import AutoHideScrollbar from './AutoHideScrollbar';
23-
import { ReactNode } from "react";
2423

2524
/**
2625
* Represents a tab for the TabbedView.

src/components/views/right_panel/RoomSummaryCard.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export const useWidgets = (room: Room) => {
7777
setApps([...WidgetStore.instance.getApps(room.roomId)]);
7878
}, [room]);
7979

80-
useEffect(updateApps, [room]);
80+
useEffect(updateApps, [room, updateApps]);
8181
useEventEmitter(WidgetStore.instance, room.roomId, updateApps);
8282
useEventEmitter(WidgetLayoutStore.instance, WidgetLayoutStore.emissionForRoom(room), updateApps);
8383

src/components/views/voip/CallView.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ See the License for the specific language governing permissions and
1515
limitations under the License.
1616
*/
1717

18-
import React, { createRef, CSSProperties, ReactNode } from 'react';
18+
import React, { createRef, CSSProperties } from 'react';
1919
import dis from '../../../dispatcher/dispatcher';
2020
import CallHandler from '../../../CallHandler';
2121
import {MatrixClientPeg} from '../../../MatrixClientPeg';

0 commit comments

Comments
 (0)