Toolchain updates. Node 18, TypeScript 5, Next 13#1938
Merged
Conversation
dsmith3197
approved these changes
Oct 29, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the visx toolchain including TypeScript, Node.js, Next.js, and replaces deprecated react-docgen-typescript-loader with a custom documentation generation script. It modernizes type imports across all packages and updates dependencies to current versions.
- Updates TypeScript from 3.8 to 5.7, Node from 16 to 18, Next.js from 11 to 13
- Replaces deprecated react-docgen-typescript-loader with custom TypeScript docgen script
- Converts all import statements to use "type" imports for type-only imports
Reviewed Changes
Copilot reviewed 297 out of 490 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Node version requirement and core dependencies |
| visx-demo/next.config.js | Removes deprecated loader and modernizes webpack config |
| visx-demo/src/utils/getDocGenInfo.ts | New utility for component documentation generation |
| visx-demo/src/types/index.ts | Enhanced type definitions for documentation |
| visx-/src/ | Converts imports to type-only imports throughout codebase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size Changes
View raw build statsPrevious (master){
"visx-annotation": {
"esm": 30333,
"lib": 40419
},
"visx-axis": {
"esm": 20709,
"lib": 25153
},
"visx-bounds": {
"esm": 2661,
"lib": 3136
},
"visx-brush": {
"esm": 55492,
"lib": 59763
},
"visx-chord": {
"esm": 3301,
"lib": 4484
},
"visx-clip-path": {
"esm": 3993,
"lib": 5491
},
"visx-curve": {
"esm": 323,
"lib": 1462
},
"visx-delaunay": {
"esm": 2422,
"lib": 3231
},
"visx-demo": {
"esm": 0,
"lib": 36814
},
"visx-drag": {
"esm": 12570,
"lib": 14176
},
"visx-event": {
"esm": 3815,
"lib": 5091
},
"visx-geo": {
"esm": 12930,
"lib": 16196
},
"visx-glyph": {
"esm": 13761,
"lib": 18476
},
"visx-gradient": {
"esm": 16078,
"lib": 20593
},
"visx-grid": {
"esm": 18097,
"lib": 21710
},
"visx-group": {
"esm": 1471,
"lib": 2070
},
"visx-heatmap": {
"esm": 7040,
"lib": 8347
},
"visx-hierarchy": {
"esm": 12093,
"lib": 17820
},
"visx-legend": {
"esm": 25546,
"lib": 32474
},
"visx-marker": {
"esm": 8204,
"lib": 10332
},
"visx-mock-data": {
"esm": 326036,
"lib": 329336
},
"visx-network": {
"esm": 4497,
"lib": 6572
},
"visx-pattern": {
"esm": 11689,
"lib": 15673
},
"visx-point": {
"esm": 1003,
"lib": 1781
},
"visx-react-spring": {
"esm": 13253,
"lib": 16586
},
"visx-responsive": {
"esm": 15936,
"lib": 18296
},
"visx-sankey": {
"esm": 3543,
"lib": 4594
},
"visx-scale": {
"esm": 18870,
"lib": 29896
},
"visx-shape": {
"esm": 81766,
"lib": 102573
},
"visx-stats": {
"esm": 13498,
"lib": 15050
},
"visx-text": {
"esm": 8276,
"lib": 9773
},
"visx-threshold": {
"esm": 2844,
"lib": 3723
},
"visx-tooltip": {
"esm": 14383,
"lib": 19715
},
"visx-vendor": {
"esm": 2492,
"lib": 2702
},
"visx-visx": {
"esm": 1524,
"lib": 4155
},
"visx-voronoi": {
"esm": 2137,
"lib": 2824
},
"visx-wordcloud": {
"esm": 2506,
"lib": 3311
},
"visx-xychart": {
"esm": 173319,
"lib": 225360
},
"visx-zoom": {
"esm": 16176,
"lib": 18872
}
}Current{
"visx-annotation": {
"esm": 30333,
"lib": 40419
},
"visx-axis": {
"esm": 20709,
"lib": 25153
},
"visx-bounds": {
"esm": 2662,
"lib": 3136
},
"visx-brush": {
"esm": 55826,
"lib": 60097
},
"visx-chord": {
"esm": 3301,
"lib": 4484
},
"visx-clip-path": {
"esm": 3993,
"lib": 5491
},
"visx-curve": {
"esm": 323,
"lib": 1462
},
"visx-delaunay": {
"esm": 2422,
"lib": 3231
},
"visx-demo": {
"esm": 0,
"lib": 0
},
"visx-drag": {
"esm": 12570,
"lib": 14176
},
"visx-event": {
"esm": 3815,
"lib": 5091
},
"visx-geo": {
"esm": 12930,
"lib": 16196
},
"visx-glyph": {
"esm": 13761,
"lib": 18476
},
"visx-gradient": {
"esm": 16078,
"lib": 20593
},
"visx-grid": {
"esm": 18164,
"lib": 22188
},
"visx-group": {
"esm": 1471,
"lib": 2070
},
"visx-heatmap": {
"esm": 7040,
"lib": 8347
},
"visx-hierarchy": {
"esm": 12093,
"lib": 17820
},
"visx-legend": {
"esm": 25964,
"lib": 32892
},
"visx-marker": {
"esm": 8204,
"lib": 10332
},
"visx-mock-data": {
"esm": 326036,
"lib": 329336
},
"visx-network": {
"esm": 4544,
"lib": 6634
},
"visx-pattern": {
"esm": 11689,
"lib": 15673
},
"visx-point": {
"esm": 1003,
"lib": 1781
},
"visx-react-spring": {
"esm": 13221,
"lib": 16485
},
"visx-responsive": {
"esm": 15936,
"lib": 18296
},
"visx-sankey": {
"esm": 3543,
"lib": 4594
},
"visx-scale": {
"esm": 19205,
"lib": 30251
},
"visx-shape": {
"esm": 81787,
"lib": 102594
},
"visx-stats": {
"esm": 13498,
"lib": 15050
},
"visx-text": {
"esm": 8297,
"lib": 9794
},
"visx-threshold": {
"esm": 2844,
"lib": 3723
},
"visx-tooltip": {
"esm": 14383,
"lib": 19715
},
"visx-vendor": {
"esm": 2492,
"lib": 2702
},
"visx-visx": {
"esm": 1524,
"lib": 4155
},
"visx-voronoi": {
"esm": 2137,
"lib": 2824
},
"visx-wordcloud": {
"esm": 2506,
"lib": 3324
},
"visx-xychart": {
"esm": 174768,
"lib": 225877
},
"visx-zoom": {
"esm": 16176,
"lib": 18872
}
} |
…BrushHandle components
hshoff
changed the title
This was referenced Nov 7, 2025
Closed
|
🎉 This PR is included in version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up where #1894 left off. The goal here was to land a
react-docgen-typescript-loaderreplacement to unblock the typescript upgrade. Then other things needed updating too.My plan was to make this PR onto @williaster's branch, but GitHub doesn't seem to like me doing that right now. So we can use this PR to consolidate.
💥 Breaking Changes
withRegisteredData🏠 Internal
18for now.20and then22will come in follow up PRs11=>133.8=>5.7@types/*updatesTesting