-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(airbyte-ci): move common_utils
into ci_credentials
#52643
Conversation
This was only used in `ci_credentials`, so we're moving it there and removing the extra package.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is mostly housekeeping, I am trying to reduce our footprint as much as possible. |
@ian-at-airbyte heads up, in your PR you changed qa-checks docs that are autogenerated. I will rewrite it here, but I'm happy to help you port your changes to the template and regenerate them. |
I'm getting a couple of type check errors which I am willing to ignore, and ci_credentials tests fine locally, but failed on CI when I last ran it. Weird. |
@natikgadzhi - This plagued me before - thank you Natik!! |
💯 |
Thanks Natik. I did not realize this file was autogenerated. |
0a38550
to
5ad365e
Compare
The tests on ci_credentials are testing in a funny way — I think tests on CI can't intercept stderr for some reason. I will merge this because they work locally just fine. |
Oh wait I can't quite merge this, I think it tests all packages, not just the changed ones, so it will start yelling red on everything |
Upd: nope, master CI actually has the same failures (outside of logger failures) and I'm okay with them. We might have to fix this down the line, but ci_credentials being internal tool, this is ok. |
What
This PR removes
common_utils
, a package that was only used inci_credentials
explicitly. I've moved the logger and google_api client into ci_credentials. Then, to clean things up:connector_ops
because they had transitive dependency oncommon_utils
.common_utils
from the list of CI checksThis also removes required reviewers checks that
connector_ops
provided. I strongly believe we should use GitHub-native actions that other folks maintain to setup required reviewers based on CODEOWNERS instead IF we actually need them.