Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions support on mobile platforms #792

Closed
alex-tsx opened this issue Jul 9, 2024 · 1 comment
Closed

Extensions support on mobile platforms #792

alex-tsx opened this issue Jul 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@alex-tsx
Copy link

alex-tsx commented Jul 9, 2024

At the moment Beacon UI does not expect to have extensions installed, when navigator.userAgent is of mobile nature. It does check their presence (pings are received by extension), but will not provide corresponding user-actions (render corresponding buttons).

Thus, there is no attempt to connect with extension at all. Noticed this, while adapting our wallet extension for mobile-first browsers.

With this consideration, UI is up to be decided, but desired effect is reflected by this PR: #791

Screen.Recording.2024-07-08.at.22.38.03.mov
Screen.Recording.2024-07-09.at.13.36.25.mov
@alex-tsx alex-tsx added the enhancement New feature or request label Jul 9, 2024
@IsaccoSordo
Copy link
Collaborator

Thank you for highlighting this behavior in the current UI and submitting a PR to address the issue.
As we are currently migrating the UI to React, any changes made in SolidJS will unfortunately be lost during the transition.
To ensure that your input is not overlooked, we have created an internal issue to revisit and integrate your change either as part of the React-based UI release or in a future patch.
Thank you once again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants