Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static validation test for events.js #13

Open
rrudol opened this issue Mar 6, 2020 · 2 comments
Open

Add static validation test for events.js #13

rrudol opened this issue Mar 6, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rrudol
Copy link
Member

rrudol commented Mar 6, 2020

Description

A small typo can destroy build. Please add a simple test that will validate the correctness of the event.js file.
@rrudol rrudol added enhancement New feature or request good first issue Good for newcomers labels Mar 6, 2020
@roertbb
Copy link
Collaborator

roertbb commented Mar 7, 2020

How would you like to achieve that? I'd suggest some Github Action running test on pull request. Do you have any other idea?

@rrudol
Copy link
Member Author

rrudol commented Mar 9, 2020

Exactly, let's prepare regular Jest test case which just loads and parse data and then let's run it using Github Actions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrudol @roertbb