Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream songs instead of pre-loading them to save memory. #58

Closed
albrow opened this issue Sep 19, 2023 · 1 comment
Closed

Stream songs instead of pre-loading them to save memory. #58

albrow opened this issue Sep 19, 2023 · 1 comment
Labels
accessibility Support for different screen sizes, platforms, etc. enhancement New feature or request music/sound effects
Milestone
Public Beta Launch

Comments

@albrow
Copy link
Owner

albrow commented Sep 19, 2023

Currently we preload all sounds, but this can cause unnecessary memory usage and make the page less responsive on initial load. Ideally we would stream music as needed instead of downloading it all at once. Sound effects are smaller files and should probably still be preloaded for now.
@albrow albrow added enhancement New feature or request music/sound effects accessibility Support for different screen sizes, platforms, etc. labels Sep 19, 2023
@albrow albrow added this to the Public Beta Launch milestone Sep 19, 2023
@albrow
Copy link
Owner Author

albrow commented Sep 19, 2023

Fixed in 53a8f4b

@albrow albrow closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Support for different screen sizes, platforms, etc. enhancement New feature or request music/sound effects
Projects
None yet
Milestone
Public Beta Launch
Development

No branches or pull requests
1 participant
@albrow