Skip to content

Commit 853135a

Browse files
authored
Fix: error 500 on get_credit_balances_handler (#972)
This pull request makes a small change to how credit balances are formatted in the `get_credit_balances_handler` function. Instead of using the `model_validate` method, it now explicitly creates `AddressCreditBalanceResponse` objects using the address and credits values from each balance.
1 parent d264402 commit 853135a

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

src/aleph/db/accessors/balances.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,8 +367,7 @@ def get_credit_balances(
367367
page: int = 1,
368368
pagination: int = 100,
369369
min_balance: int = 0,
370-
**kwargs,
371-
):
370+
) -> list[tuple[str, int]]:
372371
"""
373372
Get paginated credit balances for all addresses.
374373
Uses the cached balances from the credit_balances table.
@@ -388,7 +387,7 @@ def get_credit_balances(
388387
return [(row.address, row.balance) for row in results]
389388

390389

391-
def count_credit_balances(session: DbSession, min_balance: int = 0, **kwargs):
390+
def count_credit_balances(session: DbSession, min_balance: int = 0) -> int:
392391
"""
393392
Count addresses with credit balances.
394393
Uses the cached balances from the credit_balances table.

src/aleph/web/controllers/accounts.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,10 +221,13 @@ async def get_credit_balances_handler(request: web.Request) -> web.Response:
221221
credit_balances = get_credit_balances(session, **find_filters)
222222

223223
formatted_credit_balances = [
224-
AddressCreditBalanceResponse.model_validate(b) for b in credit_balances
224+
AddressCreditBalanceResponse(address=address, credits=credits)
225+
for address, credits in credit_balances
225226
]
226227

227-
total_credit_balances = count_credit_balances(session, **find_filters)
228+
total_credit_balances = count_credit_balances(
229+
session, find_filters.get("min_balance", 0)
230+
)
228231

229232
pagination_page = query_params.page
230233
pagination_per_page = query_params.pagination

0 commit comments

Comments
 (0)