fix(tests): pass scoring_* args to PostMessageHandler in forget fixture#1159
Merged
Conversation
PR #1150 added required scoring_addresses, scoring_channel, and scoring_metrics_post_type args to PostMessageHandler.__init__. The forget_handler fixture in tests/permissions/test_forget_permissions.py was added in PR #1156 against a base that already had those required args but did not pass them, so mypy on main fails with: Missing positional arguments "scoring_addresses", "scoring_channel", "scoring_metrics_post_type" in call to "PostMessageHandler" Match the placeholder values used by the equivalent fixture in tests/message_processing/test_process_forgets.py.
foxpatch-aleph
approved these changes
May 21, 2026
foxpatch-aleph
left a comment
foxpatch-aleph
left a comment
There was a problem hiding this comment.
Correctly passes the three required scoring_* arguments to PostMessageHandler in the forget_handler test fixture, using placeholder values identical to the equivalent fixture in tests/message_processing/test_process_forgets.py. Fixes a mypy error caused by a merge gap between PR #1150 (which added the params) and PR #1156 (which introduced the fixture).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main'scode-qualityjob is failing mypy:scoring_*args toPostMessageHandler.__init__. PR fix(forget): authorize FORGET via security-aggregate delegation #1156 introduced theforget_handlerfixture without passing them.tests/message_processing/test_process_forgets.py.Test plan
ruff/black --check/isort --checkcleanpython -c "import ast; ast.parse(...)"parses