From e71c29687d12a4a5e88b7cffcece634816b1e1e5 Mon Sep 17 00:00:00 2001 From: ewolinetz Date: Wed, 18 Jan 2017 15:29:00 -0600 Subject: [PATCH] Addressing found issues with logging role --- roles/openshift_logging/library/openshift_logging_facts.py | 4 ++-- roles/openshift_logging/tasks/generate_configmaps.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/roles/openshift_logging/library/openshift_logging_facts.py b/roles/openshift_logging/library/openshift_logging_facts.py index 8bbfdf7bf94..64bc3343517 100644 --- a/roles/openshift_logging/library/openshift_logging_facts.py +++ b/roles/openshift_logging/library/openshift_logging_facts.py @@ -105,9 +105,9 @@ def default_keys_for(self, kind): def add_facts_for(self, comp, kind, name=None, facts=None): ''' Add facts for the provided kind ''' - if comp in self.facts is False: + if comp not in self.facts: self.facts[comp] = dict() - if kind in self.facts[comp] is False: + if kind not in self.facts[comp]: self.facts[comp][kind] = dict() if name: self.facts[comp][kind][name] = facts diff --git a/roles/openshift_logging/tasks/generate_configmaps.yaml b/roles/openshift_logging/tasks/generate_configmaps.yaml index b24a7c34273..8fcf517ad3e 100644 --- a/roles/openshift_logging/tasks/generate_configmaps.yaml +++ b/roles/openshift_logging/tasks/generate_configmaps.yaml @@ -49,7 +49,7 @@ - copy: content: "{{curator_config_contents}}" dest: "{{mktemp.stdout}}/curator.yml" - when: curator_config_contenets is defined + when: curator_config_contents is defined changed_when: no - command: >