Skip to content

Commit b1ad01d

Browse files
authored
Merge pull request #274 from alexandr-g/eslint-fix
fix: update eslint-plugins that caused installation fail
2 parents 259ba5d + c4bb55b commit b1ad01d

File tree

7 files changed

+185
-262
lines changed

7 files changed

+185
-262
lines changed

README.md

+1-5
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ Eslint rules are commented for your convenience feel free to tweak or remove the
8888
To test the output of your template locally run
8989

9090
```bash
91-
npx create-react-app my-app --template file:/\path\to\file
91+
npx create-react-app my-app --template file:./cra-template-typescript-redux
9292
```
9393

9494
## How to create custom Create React App (CRA) templates
@@ -101,10 +101,6 @@ I created a step by step guide on how to create your own templates.
101101

102102
[View on dev.to](https://dev.to/alexandrg/how-to-create-custom-create-react-app-cra-templates-3nca)
103103

104-
## My other templates
105-
106-
[A light weight Create React App template with Recoil for state management](https://github.com/alexandr-g/cra-template-recoil)
107-
108104
## Thank you
109105

110106
I hope this template will be helpful for you and you will love using it 🖤

package.json

+4-3
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
"@types/node": "^14.0.0",
4040
"@types/react": "^18.2.6",
4141
"@types/react-dom": "^18.2.4",
42+
"@types/react-redux": "^7.1.25",
4243
"@types/react-router-dom": "^5.3.3",
4344
"@types/redux-mock-store": "^1.0.1",
4445
"@typescript-eslint/eslint-plugin": "^5.59.5",
@@ -47,10 +48,10 @@
4748
"eslint-config-airbnb-typescript": "^16.1.0",
4849
"eslint-config-prettier": "^8.0.0",
4950
"eslint-plugin-import": "^2.27.5",
50-
"eslint-plugin-jsx-a11y": "^6.4.1",
51+
"eslint-plugin-jsx-a11y": "^6.7.1",
5152
"eslint-plugin-prettier": "^4.0.0",
52-
"eslint-plugin-react": "^7.21.5",
53-
"eslint-plugin-react-hooks": "^4.0.8",
53+
"eslint-plugin-react": "^7.32.2",
54+
"eslint-plugin-react-hooks": "^4.6.0",
5455
"prettier": "^2.0.0",
5556
"react": "^18.2.0",
5657
"react-dom": "^18.2.0",

src/components/counter/Counter.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const Counter: React.FC = () => {
2424
<div className="card-action">
2525
<div className="group">
2626
<button
27-
className="waves-effect waves-teal btn-flat blue"
27+
className="waves-effect waves-teal btn-flat red"
2828
type="button"
2929
data-qa="decrement-counter"
3030
onClick={() =>
@@ -34,7 +34,7 @@ const Counter: React.FC = () => {
3434
decrement
3535
</button>
3636
<button
37-
className="waves-effect waves-teal btn-flat red"
37+
className="waves-effect waves-teal btn-flat blue"
3838
type="button"
3939
data-qa="increment-counter"
4040
onClick={() =>

template.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"@types/node": "14.0.0",
66
"@types/react": "18.2.6",
77
"@types/react-dom": "18.2.4",
8-
"@types/react-redux": "8.0.5",
8+
"@types/react-redux": "7.1.25",
99
"@types/react-router-dom": "5.3.3",
1010
"@types/redux-mock-store": "1.0.1",
1111
"@typescript-eslint/eslint-plugin": "5.59.5",
@@ -14,10 +14,10 @@
1414
"eslint-config-airbnb-typescript": "16.1.0",
1515
"eslint-config-prettier": "8.0.0",
1616
"eslint-plugin-import": "2.27.5",
17-
"eslint-plugin-jsx-a11y": "6.4.1",
17+
"eslint-plugin-jsx-a11y": "6.7.1",
1818
"eslint-plugin-prettier": "4.0.0",
19-
"eslint-plugin-react": "7.21.5",
20-
"eslint-plugin-react-hooks": "4.0.8",
19+
"eslint-plugin-react": "7.32.2",
20+
"eslint-plugin-react-hooks": "4.6.0",
2121
"prettier": "2.0.0",
2222
"react-redux": "8.0.5",
2323
"react-router-dom": "6.11.1",

template/src/components/counter/Counter.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const Counter: React.FC = () => {
2424
<div className="card-action">
2525
<div className="group">
2626
<button
27-
className="waves-effect waves-teal btn-flat blue"
27+
className="waves-effect waves-teal btn-flat red"
2828
type="button"
2929
data-qa="decrement-counter"
3030
onClick={() =>
@@ -34,7 +34,7 @@ const Counter: React.FC = () => {
3434
decrement
3535
</button>
3636
<button
37-
className="waves-effect waves-teal btn-flat red"
37+
className="waves-effect waves-teal btn-flat blue"
3838
type="button"
3939
data-qa="increment-counter"
4040
onClick={() =>

template/src/features/counter/counterReducer.ts

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable @typescript-eslint/default-param-last */
12
import { INCREMENT_COUNTER, DECREMENT_COUNTER } from './actionTypes'
23
import { CounterActionTypes } from './types'
34

0 commit comments

Comments
 (0)