Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install babel-eslint automatically #18

Open
alexlafroscia opened this issue Sep 7, 2018 · 0 comments
Open

Install babel-eslint automatically #18

alexlafroscia opened this issue Sep 7, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alexlafroscia
Copy link
Owner

alexlafroscia commented Sep 7, 2018 •
edited
Loading

@alansouzati pointed out to me that installing this addon makes ESLint start choking on decorators. That's not nice!

The ember-decorators repo automatically installs and configured babel-eslint if needed so that the user just don't have to worry about it. I want to do the same thing here.

Alternatively, if that's too hard, we can just issue a warning on install (or even in the README) but if I can just do the "hard part" myself I might as well.

Related to #16
@alexlafroscia alexlafroscia added enhancement New feature or request good first issue Good for newcomers labels Sep 7, 2018
@alexlafroscia alexlafroscia changed the title Install babel-eslint by default Install babel-eslint automatically Sep 7, 2018
@alexlafroscia alexlafroscia mentioned this issue Sep 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexlafroscia