Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using this.attrs #22

Open
2 tasks
alexlafroscia opened this issue Sep 11, 2018 · 0 comments
Open
2 tasks

Avoid using this.attrs #22

alexlafroscia opened this issue Sep 11, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@alexlafroscia
Copy link
Owner

We currently use this.attrs to get all of the things passed to the Ember invocation of a component and use them as the props on the React component.

This API is not public and should be avoided.

We need to:

  • Investigate a different way to get all of the arguments to a component in JavaScript (there is already a Handlebars API for this, but that doesn't help us)
  • Update the implementation
@alexlafroscia alexlafroscia added the enhancement New feature or request label Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexlafroscia