Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputFile and lazy loading react/react-dom #33

Open
jbailey4 opened this issue Jun 12, 2019 · 1 comment
Open

outputFile and lazy loading react/react-dom #33

jbailey4 opened this issue Jun 12, 2019 · 1 comment

Comments

@jbailey4
Copy link

This is a great addon and the use of a decorator to add React support within Ember is a nice solution.

Everything is working great at runtime, however, using the outputFile config option to lazy load react/react-dom is not actually splitting out the dependencies in a separate file.

I also tried to just use dynamic imports to load react and react-dom, since the app I work on also has ember-auto-import, but this doesn't work either.

It seems like react and react-dom always get added to the consuming app's vendor.js.

@VincentMolinie
Copy link

I do have the same issue 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants