Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Ember Octane compatibility #41

Open
auvipy opened this issue Dec 23, 2019 · 3 comments
Open

Ensure Ember Octane compatibility #41

auvipy opened this issue Dec 23, 2019 · 3 comments

Comments

@auvipy
Copy link

auvipy commented Dec 23, 2019

No description provided.

@shamrt
Copy link

shamrt commented Jun 3, 2021

A year-and-a-half later, I'm working on this, and plan to submit a PR in the next little bit.

It'll be a breaking change, but that's the nature of moving from classic components to Glimmer 🤷

@shamrt
Copy link

shamrt commented Jun 10, 2021

As mentioned in #62, turns out migrating to Glimmer was technically infeasible, so I did the next best thing: updated the addon to Ember v3.18 and added a feature for providing arbitrary mixin props to the component wrapper.

@shamrt
Copy link

shamrt commented Jun 11, 2021

If anyone wants to use the results of this modernization before it is merged into upstream and published, I've published a fork in my company's npm org: https://www.npmjs.com/package/@rewardops-forks/ember-react-components. If and when @alexlafroscia accepts my PR, we plan to switch back to his package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants